Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: erlang-riak_sysmon - Rate-limiting system_monitor event handler for Riak
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Summary: Review Request: erlang-riak_sysmon - Rate-limiting system_monitor event handler for Riak Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lemenkov@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://peter.fedorapeople.org/erlang-riak_sysmon.spec SRPM URL: http://peter.fedorapeople.org/erlang-riak_sysmon-1.0.0-1.fc16.src.rpm Description: Simple OTP app for managing Erlang VM system_monitor event messages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652598 Status Whiteboard| |NotReady
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |639263
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|NotReady |
--- Comment #1 from Peter Lemenkov lemenkov@gmail.com 2012-05-15 13:55:06 EDT --- Lifted NotReady and updated to 1.1.2:
http://peter.fedorapeople.org/erlang-riak_sysmon.spec http://peter.fedorapeople.org/erlang-riak_sysmon-1.1.2-1.fc18.src.rpm
Koji scratchbuild for F-18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4079575
rpmlint:
sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/erlang-riak_sysmon-1.1.2-1.fc18.ppc.rpm ../SRPMS/erlang-riak_sysmon-1.1.2-1.fc18.src.rpm erlang-riak_sysmon.ppc: E: explicit-lib-dependency erlang-stdlib
^^^ this one is a false positive (stdlib as a trigger)
erlang-riak_sysmon.ppc: E: no-binary erlang-riak_sysmon.ppc: W: only-non-binary-in-usr-lib
^^^ this one is tricky. All erlang packages must be installed into %{_libdir}/erlang/lib so despite of the fact that some of them contains only arch-independent data they all must be build as arch-dependent. I plan to fix than but I wouldn't hold my breath.
erlang-riak_sysmon.src: W: invalid-url Source0: basho-riak_sysmon-1.1.2-0-gaab7706.tar.gz
^^^ blame github for that, not me.
2 packages and 0 specfiles checked; 2 errors, 2 warnings. sulaco ~/rpmbuild/SPECS:
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org Assignee|nobody@fedoraproject.org |misc@zarb.org
--- Comment #2 from Michael Scherer misc@zarb.org --- Hi,
- why is debug package disabled ? ( I assume that's because that's erlang, but in the absence of mention in the draft erlang packaging policy, I prefer to ask )
- lots of stuff are not needed anymore for newer Fedora :
%clean rm -rf $RPM_BUILD_ROOT
rm -Rf in the beginning of %install
%defattr(-,root,root,-)
BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
- could you explain how the test fail in koji ( at least, with a comment ? )
otherwise, this seems good, let me start the review.
https://bugzilla.redhat.com/show_bug.cgi?id=739015
--- Comment #3 from Michael Scherer misc@zarb.org ---
Package Review ==============
Key: - = N/A x = Pass ! = Fail ? = Not evaluated
==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL [x]: MUST Sources contain only permissible code or content. [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [!]: MUST Package consistently uses macros (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [-]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. Note: Package has no sources or they are generated by developer [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [!]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [-]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
Issues: [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [!]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShor... [!]: MUST Package consistently uses macros (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
Rpmlint ------- Checking: erlang-riak_sysmon-1.1.2-1.fc18.src.rpm erlang-riak_sysmon-1.1.2-1.fc18.i686.rpm erlang-riak_sysmon.src: W: invalid-url Source0: basho-riak_sysmon-1.1.2-0-gaab7706.tar.gz erlang-riak_sysmon.i686: E: explicit-lib-dependency erlang-stdlib erlang-riak_sysmon.i686: E: no-binary erlang-riak_sysmon.i686: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 2 errors, 2 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- /var/lib/mock/fedora-rawhide-i386/result/erlang-riak_sysmon-1.1.2-1.fc18.i686.rpm: erlang-erts erlang-kernel erlang-stdlib
Provides -------- /var/lib/mock/fedora-rawhide-i386/result/erlang-riak_sysmon-1.1.2-1.fc18.i686.rpm: erlang-riak_sysmon = 1.1.2-1.fc18 erlang-riak_sysmon(x86-32) = 1.1.2-1.fc18
Generated by fedora-review 0.2.0git External plugins:
So there is some stuff to clean, and I do not know how to test it, I assume there is one simple command line to start the erlang application ?
( again, if this is the same type of command every time, maybe that should be added to the packaging guideline )
https://bugzilla.redhat.com/show_bug.cgi?id=739015
--- Comment #4 from Peter Lemenkov lemenkov@gmail.com --- First of all thanks for picking this up, Michael!
(In reply to comment #2)
Hi,
- why is debug package disabled ?
( I assume that's because that's erlang, but in the absence of mention in the draft erlang packaging policy, I prefer to ask )
Yep, that's one of the currrent Erlang shortcomings. Every module must be installed into %{_libdir}/erlang/lib (actually "should" not "must", but otherwise it requires some manual intervention and several changes into application's sources). And since %{_libdir} is arch-dependent the entire package becomes arch-dependent as well. To suppress useless debuginfo generation we're using "%global debug_package %{nil}" directive at the top of the packages like this.
This definitely looks ugly, and I plan to fix it in the future. Also I apologise for absence of Erlang Packaging Policy - we'll probably come up with something worth to reading before F-19.
- lots of stuff are not needed anymore for newer Fedora :
%clean rm -rf $RPM_BUILD_ROOT
rm -Rf in the beginning of %install
%defattr(-,root,root,-)
BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
Actually my primary goal is EL6 (and I'm considering EL5 as well) so I have to keep vintage stuff.
- could you explain how the test fail in koji ( at least, with a comment ? )
Yep. that was my fault - I didn't realise that I need to start epmd daemon before running tests. Erlang Port Monitor Daemon is a generic service which allows different local and remote Erlang nodes to exchange data. Since this package is exactly about monitoring of data exchange channels then it requires epmd to run. Sorry for that - I provided fixed version:
http://peter.fedorapeople.org/erlang-riak_sysmon.spec http://peter.fedorapeople.org/erlang-riak_sysmon-1.1.2-2.fc18.src.rpm
Koji scratchbuild for F-18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4093357
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(misc@zarb.org)
--- Comment #5 from Peter Lemenkov lemenkov@gmail.com --- Ping, Michael! :)
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(misc@zarb.org) |
--- Comment #6 from Michael Scherer misc@zarb.org --- For some reason, mock complain : State Changed: end DEBUG: kill orphans WARNING: Process ID 4037 still running in chroot. Killing...
I guess that's the %check, you need to kill epmd if you start it :)
For the rest, it seems that you corrected everything
Could you correct the last part about %check, and I will approve it.
https://bugzilla.redhat.com/show_bug.cgi?id=739015
--- Comment #7 from Peter Lemenkov lemenkov@gmail.com --- (In reply to comment #6)
For some reason, mock complain : State Changed: end DEBUG: kill orphans WARNING: Process ID 4037 still running in chroot. Killing...
I guess that's the %check, you need to kill epmd if you start it :)
Good catch, thanks!
* http://peter.fedorapeople.org/erlang-riak_sysmon.spec * http://peter.fedorapeople.org/erlang-riak_sysmon-1.1.2-3.fc18.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(misc@zarb.org)
--- Comment #8 from Peter Lemenkov lemenkov@gmail.com --- Ping again, Michael! :)
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review?, |fedora-review+ |needinfo?(misc@zarb.org) |
--- Comment #9 from Michael Scherer misc@zarb.org --- Seems good to go with the latest modification
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #10 from Peter Lemenkov lemenkov@gmail.com --- Thanks!
New Package SCM Request ======================= Package Name: erlang-riak_sysmon Short Description: Rate-limiting system_monitor event handler for Riak Owners: peter Branches: f16 f17 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=739015
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=739015
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- erlang-riak_sysmon-1.1.2-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/erlang-riak_sysmon-1.1.2-3.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=739015
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- erlang-riak_sysmon-1.1.2-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/erlang-riak_sysmon-1.1.2-3.el6
https://bugzilla.redhat.com/show_bug.cgi?id=739015
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- erlang-riak_sysmon-1.1.2-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/erlang-riak_sysmon-1.1.2-3.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- erlang-riak_sysmon-1.1.2-3.fc17 has been pushed to the Fedora 17 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=739015
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-06-19 20:21:30
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- erlang-riak_sysmon-1.1.2-3.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=739015
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- erlang-riak_sysmon-1.1.2-3.fc16 has been pushed to the Fedora 16 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=739015
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- erlang-riak_sysmon-1.1.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org