Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: surl - A URL shortening command line tool
https://bugzilla.redhat.com/show_bug.cgi?id=512272
Summary: Review Request: surl - A URL shortening command line tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fabian@bernewireless.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/surl.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/surl-0.5.1-1.fc11.src.rpm
Project URL: https://launchpad.net/surl
Description: surl is a URL shortening command line application that supports various sites. It supports stdin or filename input. It grabs the URLs, converts them, and returns the same text that was used in the input. It is known to work with a wealth of services, such as bit.ly, tinyurl.com and tr.im.
The currently supported sites are a.gd, bit.ly, burnurl.com, cli.gs, decenturl.com, digg.com, is.gd, kl.am, liip.to, metamark.net, sn.im, snipr.com, snipurl.com, snurl.com, tinyurl.com, tr.im, turl.ca, ur.ly, and zz.gd.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1480612
rpmlint output: [fab@laptop09 SRPMS]$ rpmlint surl-0.5.1-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[fab@laptop09 noarch]$ rpmlint surl-0.5.1-1.fc11.noarch.rpm surl.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/surl/surl.py 0644 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
This should not be a problem because surl.py is called by /bin/surl.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi
--- Comment #1 from Jussi Lehtola jussi.lehtola@iki.fi 2009-07-17 07:27:14 EDT --- You can get rid of the rpmlint error by removing the shebang from the library file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
--- Comment #2 from Fabian Affolter fabian@bernewireless.net 2009-07-17 08:04:47 EDT --- For me this is not working because this ends with an error:
/usr/bin/surl: Zeile 1: surl - a URL shortening application, supports various sites : Kommando nicht gefunden.
After the changing of the permission, rpm added as requirement '/bin/python'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
--- Comment #3 from Jussi Lehtola jussi.lehtola@iki.fi 2009-07-17 08:22:41 EDT --- (In reply to comment #2)
For me this is not working because this ends with an error:
/usr/bin/surl: Zeile 1: surl - a URL shortening application, supports various sites : Kommando nicht gefunden.
After the changing of the permission, rpm added as requirement '/bin/python'
Python libraries are not supposed to be executable.
After install just execute sed -i -e '/^#!//, 1d' %{buildroot}%{python_sitelib}/%{name}/surl.py
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
--- Comment #4 from Fabian Affolter fabian@bernewireless.net 2009-07-17 08:40:02 EDT --- I placed the stuff in the wrong section. Thanks for your help, Jussi.
Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/surl.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/surl-0.5.1-2.fc11.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |jussi.lehtola@iki.fi Flag| |fedora-review+
--- Comment #5 from Jussi Lehtola jussi.lehtola@iki.fi 2009-07-17 08:50:53 EDT --- rpmlint output is clean.
MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. N/A MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSWORK - Add PKG-INFO.
MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK
Fix the spec before importing to CVS. The package has been
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
--- Comment #6 from Fabian Affolter fabian@bernewireless.net 2009-07-17 09:11:36 EDT --- Thanks for the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Fabian Affolter fabian@bernewireless.net 2009-07-17 09:12:12 EDT --- New Package CVS Request ======================= Package Name: surl Short Description: A URL shortening command line tool Owners: fab Branches: F-10 F-11 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #8 from Jason Tibbitts tibbs@math.uh.edu 2009-07-17 11:48:57 EDT --- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
Savvas Radevic vicedar@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vicedar@gmail.com
--- Comment #9 from Savvas Radevic vicedar@gmail.com 2009-07-23 10:54:35 EDT --- Thank you for the tip as well :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-07-28 13:30:11 EDT --- surl-0.5.4-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/surl-0.5.4-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-07-29 17:28:01 EDT --- surl-0.5.4-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update surl'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8077
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-08-04 20:37:53 EDT --- surl-0.5.4-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512272
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0.5.4-1.fc11 Resolution| |ERRATA
package-review@lists.fedoraproject.org