Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: b43-tools - Tools for the Broadcom 43xx series WLAN chip
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Summary: Review Request: b43-tools - Tools for the Broadcom 43xx series WLAN chip Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lemenkov@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://peter.fedorapeople.org/b43-tools.spec SRPM URL: http://peter.fedorapeople.org/b43-tools-0-0.1.git20090125.fc10.src.rpm Description: Tools for the Broadcom 43xx series WLAN chip.
This package is a requirement for building opensource firmware for bcm43xx-based wi-fi modules.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |490892
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Keith G. Robertson-Turner redhat-bugzilla@slated.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |redhat-bugzilla@slated.org
--- Comment #1 from Keith G. Robertson-Turner redhat-bugzilla@slated.org 2009-04-03 22:01:30 EDT --- Missing BuildRequires: python-devel
+ cd debug + python install.py install --skip-build --root /var/tmp/b43-tools-0-0.1.git20090125.blag90001-QEJNVW running install error: invalid Python installation: unable to open /usr/lib64/python2.5/config/Makefile (No such file or directory) error: Bad exit status from /var/tmp/rpm-tmp.65195 (%install)
Please consider using Mach/Mock for clean chroot builds, as this will identify missing deps at an early stage.
Thanks for the package, I need this now I'm running a linux-libre kernel (b43 deblobbed)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #2 from Keith G. Robertson-Turner redhat-bugzilla@slated.org 2009-04-03 22:34:57 EDT --- Test build succeeded. b43-asm successfully assembled OpenFWWF b43 firmware. Module inserts into kernel (with qos=0 option). NetworkManager establishes WiFi connection. Network responsive and shows no degradation.
+1 publish (after fixing missing BuildRequires: python, python-devel)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #3 from Peter Lemenkov lemenkov@gmail.com 2009-04-04 02:13:53 EDT --- Added missing BR.
http://peter.fedorapeople.org/b43-tools.spec http://peter.fedorapeople.org/b43-tools-0-0.2.git20090125.fc10.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #4 from Peter Lemenkov lemenkov@gmail.com 2009-05-19 08:45:48 EDT --- New revision.
%changelog * Tue May 19 2009 Peter Lemenkov lemenkov@gmail.com 0-0.3.git20090125 - Corrected 'License' field - Since now ssb_sprom honours optflags
http://peter.fedorapeople.org/b43-tools.spec http://peter.fedorapeople.org/b43-tools-0-0.3.git20090125.fc10.src.rpm
Koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=1363009
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Alexey Torkhov atorkhov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |atorkhov@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Alexey Torkhov atorkhov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #5 from Alexey Torkhov atorkhov@gmail.com 2009-05-19 15:21:08 EDT --- Pretty simple and clean package. Here is full review:
+ rpmlint output clean + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + File, containing the text of the licenses for the package is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source. + The package successfully compiles and builds into binary rpms on at least one primary architecture (x86_64). + All build dependencies are listed in BuildRequires. + No need to deal with locales. + Does not contain shared libraries. + The package does not designed to be relocatable. + A package owns all directories that it creates. + A package does not list a file more than once in the spec %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. + The package consistently uses macros. + The package contains code, or permissible content. + Does not contain large documentation files. + Includes only doc files in %doc. + No headers. + No static libraries. + The package does not contain pkgconfig(.pc) files. + The package does not contain library files with a suffix (e.g. libfoo.so.1.1). + No devel packages. + The package does not contain any .la libtool archives. + Does not contain GUI applications. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT. + All filenames in the package are valid UTF-8.
This package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Peter Lemenkov lemenkov@gmail.com 2009-05-19 15:45:12 EDT --- New Package CVS Request ======================= Package Name: b43-tools Short Description: Tools for the Broadcom 43xx series WLAN chip Owners: peter Branches: EL-4 EL-5 F-9 F-10 F-11 InitialCC: peter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2009-05-20 01:39:27 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-05-20 04:29:32 EDT --- b43-tools-0-0.3.git20090125.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/b43-tools-0-0.3.git20090125.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-05-20 04:29:39 EDT --- b43-tools-0-0.3.git20090125.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/b43-tools-0-0.3.git20090125.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-05-20 04:29:46 EDT --- b43-tools-0-0.3.git20090125.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/b43-tools-0-0.3.git20090125.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-05-20 19:54:37 EDT --- b43-tools-0-0.3.git20090125.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update b43-tools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-5239
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-05-20 19:57:24 EDT --- b43-tools-0-0.3.git20090125.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update b43-tools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-5256
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2009-05-20 19:59:55 EDT --- b43-tools-0-0.3.git20090125.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update b43-tools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-5262
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2009-06-15 21:21:32 EDT --- b43-tools-0-0.3.git20090125.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0-0.3.git20090125.fc11 Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2009-06-15 21:40:47 EDT --- b43-tools-0-0.3.git20090125.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0-0.3.git20090125.fc11 |0-0.3.git20090125.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2009-06-15 22:00:06 EDT --- b43-tools-0-0.3.git20090125.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490638
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0-0.3.git20090125.fc9 |0-0.3.git20090125.fc10
package-review@lists.fedoraproject.org