https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Bug ID: 1110823 Summary: Review Request: perl-generators - Perl dependencies generators Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://jplesnik.fedorapeople.org/perl-generators/perl-generators.spec SRPM URL: http://jplesnik.fedorapeople.org/perl-generators/perl-generators-1.00-1.fc21... Description: This package provides Perl generators which are used for getting provides and requires from Perl binaries and modules.
Fedora Account System Username: jplesnik
The files perl.[prov|req] and perl[|lib].attr will be removed from rpm-build before publishing .
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #1 from Petr Šabata psabata@redhat.com --- The perl.prov and perl.req scripts headers should be updated not to refer to rpm and its packaging now that they're standalone components. The headers also imply the license text is present in the package whereas it's not.
Also, both scripts are licensed under GPL with no version declared; the package License should be `GPL+'.
And finally, consider using `install -p' instead of `cp' on line 37.
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com
--- Comment #2 from Petr Pisar ppisar@redhat.com --- I would prefer the package summary clearly states that this package is about RPM generators (Perl RPM dependencies generators).
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #3 from Jitka Plesnikova jplesnik@redhat.com --- Updated. Links are the same.
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Petr Šabata psabata@redhat.com --- I would put it the other way around, `RPM Perl dependencies'. Also, there's a trailing space on the License line.
Anyhow, the reported issues are fixed; approving.
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Jitka Plesnikova jplesnik@redhat.com --- New Package SCM Request ======================= Package Name: perl-generators Short Description: RPM Perl dependencies generators Upstream URL: http://jplesnik.fedorapeople.org/generators Owners: jplesnik ppisar psabata Branches: InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-generators-1.00-1.fc21 Resolution|--- |RAWHIDE Last Closed| |2014-06-25 09:19:48
--- Comment #7 from Jitka Plesnikova jplesnik@redhat.com --- Thank you for the review and the repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Orion Poplawski orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |orion@cora.nwra.com
--- Comment #8 from Orion Poplawski orion@cora.nwra.com --- Can we get an empty package in EPEL that requires rpm-build?
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #9 from Petr Pisar ppisar@redhat.com --- We can. I will do it.
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-generators-1.08-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-99a514bd17
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-generators-1.08-4.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8e1dae0f9c
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-generators-1.08-4.el5 has been submitted as an update to Fedora EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4b6ed19b8b
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords| |Reopened
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-generators-1.08-4.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4b6ed19b8b
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-generators-1.08-4.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8e1dae0f9c
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- perl-generators-1.08-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-99a514bd17
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2014-06-25 09:19:48 |2016-07-09 16:18:35
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- perl-generators-1.08-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- perl-generators-1.08-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1110823
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- perl-generators-1.08-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org