https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Bug ID: 1268372 Summary: Review Request: openstack-app-catalog-ui - openstack horizon plugin for theopenstack app-catalog Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: Kevin.Fox@pnnl.gov QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://efox.cc/temp/openstack-app-catalog-ui.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1879/11311879/openstack-app-c... Description: This package provides an OpenStack Horizon plugin to allow easy access to assets stored in the OpenStack App Catalog. Fedora Account System Username: kfox1111
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Kevin Fox Kevin.Fox@pnnl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |openstack-app-catalog-ui - |openstack-app-catalog-ui - |openstack horizon plugin |openstack horizon plugin |for theopenstack |for the openstack |app-catalog |app-catalog
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Kevin Fox Kevin.Fox@pnnl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1243533 | |(RDO-LIBERTY-REVIEWS)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1243533 [Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@redhat.com Assignee|nobody@fedoraproject.org |mrunge@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #1 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- social's scratch build of openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 for git://pkgs.fedoraproject.org/openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 and rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11426591
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #2 from Kevin Fox Kevin.Fox@pnnl.gov --- ?
Was the wrong bug commented on?
Also, PING. This has been hung up for a while.
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #3 from Matthias Runge mrunge@redhat.com --- Uhm, sorry!
The comment was definitely wrong here.
Could you please update the spec with something like this? https://github.com/mrunge/app-catalog-ui/blob/rpm-master/openstack-app-catal...
Since your tests (in %check) do nothing, you could safely remove many BuildRequirements
Once upstream uses tests, we can add them back and use upstreams unittests.
additional to my proposal, you can safely remove Requires: python-scss (as it's a requirement of openstack-dashboard)
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #4 from Haïkel Guémar karlthered@gmail.com --- *** Bug 1264072 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Alan Pevec apevec@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |apevec@gmail.com, | |Kevin.Fox@pnnl.gov Flags| |needinfo?(Kevin.Fox@pnnl.go | |v)
--- Comment #5 from Alan Pevec apevec@gmail.com --- To proceed, please update your draft spec according to comment 3
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #6 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- kfox1111's scratch build of openstack-app-catalog-ui-1.0.0-0.1rc1.el7.centos.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11477584
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Kevin Fox Kevin.Fox@pnnl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(Kevin.Fox@pnnl.go | |v) |
--- Comment #7 from Kevin Fox Kevin.Fox@pnnl.gov --- Thanks for the reviews. I merged in all of Matthias's suggestions. I also updated it to work with the final 1.0.0 release. The links are updated below:
Spec URL: http://efox.cc/temp/openstack-app-catalog-ui.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8038/11478038/openstack-app-c... Description: This package provides an OpenStack Horizon plugin to allow easy access to assets stored in the OpenStack App Catalog. Fedora Account System Username: kfox1111
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #8 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- social's scratch build of openstack-puppet-modules?#8564064dd63e71ab2156e7b49e0ab0305ad76da5 for git://pkgs.fedoraproject.org/openstack-puppet-modules?#8564064dd63e71ab2156e7b49e0ab0305ad76da5 and rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11513243
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #9 from Kevin Fox Kevin.Fox@pnnl.gov --- Again, seems like upstream release monitoring is marking the wrong bug?
Any other comments on this submission? Is it good to go? Anything else I can do?
Thanks, Kevin
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #10 from Matthias Runge mrunge@redhat.com --- Kevin, please be a bit more patient with me. I have been offline over the past week and will be traveling next week.
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #11 from Kevin Fox Kevin.Fox@pnnl.gov --- Hi Matthias,
Sorry. I understand how busy it is during a major release and with the summit. I really do. I was asking to ensure things weren't being held up by me.
Our goal was to get it in before the summit so we could announce things and that's looking like its just not going to happen. It has been months trying to get the package through. I'm not blaming you, or anyone else. If anything, I'm blaming myself for not understanding the process well enough.
This is on the critical path to getting it contributed to other projects, like tripleo, packstack, kolla, openstack-ansible, openstack-chef, openstack-puppet, etc. Its a very large amount of work left todo and we were hoping to spend the summit working on reaching out to those teams to get support going and its harder to do when the packages aren't ready.
Anyway, what can I do to help get this through as quickly as possible? If the answer is there's just isnt anything todo and has to wait till after the summit, that's fine. We'll just have to figure out a plan B for the summit.
Thanks, Kevin
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #12 from Matthias Runge mrunge@redhat.com --- Kevin, when I get a minute (or two), I'll proceed with the review.
Have you submitted (or reviewed) any other packages for Fedora yet?
There are a few pointers (or requirements for new contributors to Fedora (and RDO, EPEL)):
There is a workflow described here:
https://fedoraproject.org/wiki/Package_Review_Process
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
I should be probably the one sponsoring you into the packager group. Are you going to be in Tokyo? I *might* find some time on Tuesday to do a proper review.
Maybe Alan is able to pull in your package into RDO, even if it's not approved yet.
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #13 from Kevin Fox Kevin.Fox@pnnl.gov --- Matthias, Thanks for the help. I really appreciate it.
I haven't submitted any other packages to Fedora, so I'll have to figure that part out. Thanks for the links. I'll go through them today.
Yeah, I'll be at the summit too. I was planning on attending the RDO community meetup on 12:45 on Wednesday. Will you be there?
Alan, do you think that would be ok? We do want to get into Fedora properly. The timing is just not ideal.
Thanks, Kevin
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #14 from Matthias Runge mrunge@redhat.com --- Kevin, I'll be there.
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Kevin Fox Kevin.Fox@pnnl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Release|--- |Kilo Component|Package Review |dib-utils Version|rawhide |Liberty Product|Fedora |RDO Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Kevin Fox Kevin.Fox@pnnl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|dib-utils |Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #15 from Kevin Fox Kevin.Fox@pnnl.gov --- Matthias, I was there, but didn't manage to catch up with you. Sorry. :/
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #16 from Matthias Runge mrunge@redhat.com --- flake8 is not used during build, pleae remove it as well
I would use truncate -s 0 {test-,}requirements.txt instead of removing that files
Otherwise looks good.
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #17 from Kevin Fox Kevin.Fox@pnnl.gov --- Hi Matthias,
Thanks for the review. I've included the changes. Please find the revisions below:
Spec URL: http://efox.cc/temp/openstack-app-catalog-ui.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3823/11623823/openstack-app-c... Description: This package provides an OpenStack Horizon plugin to allow easy access to assets stored in the OpenStack App Catalog. Fedora Account System Username: kfox1111
Thanks, Kevin
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(apevec@gmail.com)
--- Comment #18 from Matthias Runge mrunge@redhat.com --- I'd approve this package, it looks sane to me.
Thank you for your patience, Kevin.
Alan, how to proceed from here now? There is no flag to set, if it was a fedora review, I'd approve the package.
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #19 from Kevin Fox Kevin.Fox@pnnl.gov --- Ping
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #20 from Kevin Fox Kevin.Fox@pnnl.gov --- PING
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Alan Pevec apevec@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |apevec@redhat.com
--- Comment #21 from Alan Pevec apevec@redhat.com --- Sorry I missed ping, bad filter on my gmail :( This package is RDO only, we're not going to push it to Fedora (NB Product: RDO ) and next step is to import it to openstack-package rpm-master, I'll do that now.
From there we import it to CBS Koji and build it for RDO testing repo, then
after verification move to production.
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #22 from Kevin Fox Kevin.Fox@pnnl.gov --- Awesome. Thank you. :)
Yeah, I've been bitten by gmail filters before too. no worries.
Thanks, Kevin
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #23 from Alan Pevec apevec@redhat.com --- Imported and adjusted for delorean builds https://github.com/openstack-packages/apps-catalog-ui
Also imported to gerrithub, for further .spec changes please send gerrit reviews. First test review: https://review.gerrithub.io/252737
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #24 from Kevin Fox Kevin.Fox@pnnl.gov --- So what are the next steps?
I just relied the repo name doesn't match the openstack-packages name. it was renamed on import into the github.com/openstack namespace. its now app-catalog-ui.
Is this something we can easily change, or should we just point to the apps name in rdoinfo?
Thanks, Kevin
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #25 from Alan Pevec apevec@redhat.com --- Actually, I made a typo and created wrong openstack-packages/apps-catalog-ui - it should be upstream project name, app-catalog-ui, I'll rename it.
PR for redhat-openstack/rdoinfo would look like:
- project: app-catalog-ui conf: core maintainers: - Kevin.Fox@pnnl.gov
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #26 from Alan Pevec apevec@redhat.com --- Rename done on github and gerrithub, please send rdoinfo PR.
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Alan Pevec apevec@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(Kevin.Fox@pnnl.go | |v)
--- Comment #27 from Alan Pevec apevec@redhat.com --- Kevin, I've created rdoinfo change in your name, please ack https://github.com/redhat-openstack/rdoinfo/pull/125
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Kevin Fox Kevin.Fox@pnnl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(apevec@gmail.com) | |needinfo?(Kevin.Fox@pnnl.go | |v) |
--- Comment #28 from Kevin Fox Kevin.Fox@pnnl.gov --- Thank you for creating it. I've been trying to get delorean to build stuff for the last few days. I did an git pull and it broke. :/
I just tried a fresh checkout and get in the build logs: ++ cd /home/kfox/svn/delorean3/data/openstack-app-catalog-ui ++ git clean -dxf + for FILE in '{test-,}requirements.txt' + '[' -f test-requirements.txt ']' + sed -i 's/;python_version[!=<>]=?.*//g' test-requirements.txt + sed -i 's/;sys_platform[!=<>]=?.*//g' test-requirements.txt + for FILE in '{test-,}requirements.txt' + '[' -f requirements.txt ']' ++ dirname /home/kfox/svn/delorean3/scripts/build_rpm.sh + /usr/bin/mock -q -r /home/kfox/svn/delorean3/scripts/delorean.cfg --clean The password you typed is invalid. Please try again. + finalize + rm -rf /tmp/tmp.I5oS6kEWrY
Is it no longer using docker to do the builds?
Thanks, Keivn
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
--- Comment #29 from Kevin Fox Kevin.Fox@pnnl.gov --- yup.
commit 66571fce45a007bcf49fd54ad7db622fd737874f Merge: 33baf8a 1e56c11 Author: Alan Pevec alan.pevec@redhat.com Date: Fri Oct 2 16:33:05 2015 +0200
Merge "Use mock instead of a custom docker machinery to build packages"
doing this: git checkout 33baf8a796cf75cd0baaab062ccb91432f1489d3
made it work for me again, and the rdoinfo pull request seems to do the job.
Thanks, Kevin
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG Last Closed| |2016-01-11 04:27:00
--- Comment #30 from Matthias Runge mrunge@redhat.com --- closing this, since it seems to be included now.
https://bugzilla.redhat.com/show_bug.cgi?id=1268372
Alan Pevec apevec@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTABUG |CURRENTRELEASE
package-review@lists.fedoraproject.org