Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226429
Summary: Merge Review: sqlite Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: pnasrat@redhat.com
Fedora Merge Review: sqlite
http://cvs.fedora.redhat.com/viewcvs/devel/sqlite/ Initial Owner: pnasrat@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226429
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wtogami@redhat.com
------- Additional Comments From wtogami@redhat.com 2007-02-01 14:13 EST ------- https://www.redhat.com/archives/fedora-extras-commits/2005-April/msg01144.ht...
Well, this was a pre-Bugzilla review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |426387 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |sqlite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |rnorwood@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
------- Additional Comments From rnorwood@redhat.com 2008-01-11 22:30 EST ------- Package review:
- rpmlint checks return:
sqlite-3.5.4-2.fc9.src.rpm -
sqlite.src:14: W: unversioned-explicit-obsoletes sqlite3 sqlite.src:14: W: unversioned-explicit-obsoletes sqlite3-devel
sqlite3 last appeared (AFAICT) in FC-3's extras. Since it's more than 3 releases old, we can drop this obsoletes. Also, the matching 'provides' are missing.
sqlite.src: W: mixed-use-of-spaces-and-tabs (spaces: line 57, tab: line 11)
Easy to fix.
sqlite-devel-3.5.4-2.fc9.i386.rpm -
sqlite-devel.i386: W: summary-ended-with-dot Development tools for the sqlite3 embeddable SQL database engine.
* both of the above are fixed in the attached patch to the spec file. *
sqlite-tcl-3.5.4-2.fc9.i386.rpm -
sqlite-tcl.i386: W: no-documentation
* Can probably be ignored
sqlite-tcl.i386: W: summary-ended-with-dot Tcl module for the sqlite3 embeddable SQL database engine.
* fixed in attached patch
sqlite-tcl.i386: E: arch-dependent-file-in-usr-share /usr/share/tcl8.5/sqlite3/libtclsqlite3.so sqlite-tcl.i386: W: unstripped-binary-or-object /usr/share/tcl8.5/sqlite3/libtclsqlite3.so
* This is obviously wrong, they should be in /usr/lib - I'm not sure what to do to fix this properly, however.
- package meets naming guidelines - Ok - license ( ) OK, text in %doc, matches source - Ok - Public Domain - spec file legible, in am. english - Ok - source matches upstream - Ok - package compiles on devel (x86) - Ok - no missing BR - Ok - no unnecessary BR - Ok - no locales - Ok - not relocatable - Ok - owns all directories that it creates - Ok - no duplicate files - Ok - permissions ok - Ok - %clean - Ok - macro use consistent - Ok - code, not content - Ok - no need for -docs - Ok - nothing in %doc affects runtime - Ok - no need for .desktop file - Ok - devel package ok - Ok - no .la files - removed in %install section - post/postun ldconfig ok - Ok - devel requires base package n-v-r - Ok
- Tests are not run by default.
* This is probably because several tests fail. I've enabled tests in the attached specfile patch, and included patches which fix or comment out the tests that fail. Someone needs to check to see why the failing tests are failing, and either fix the tests upstream, fix the bug upstream, or figure out why the tests fail for us.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
------- Additional Comments From rnorwood@redhat.com 2008-01-11 22:34 EST ------- Created an attachment (id=291445) --> (https://bugzilla.redhat.com/attachment.cgi?id=291445&action=view) patch to specfile to fix some package review issues
this patch to the specfile fixes some of the package review issues, and enables make check
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
------- Additional Comments From rnorwood@redhat.com 2008-01-11 22:35 EST ------- Created an attachment (id=291446) --> (https://bugzilla.redhat.com/attachment.cgi?id=291446&action=view) use .so instead of .la files when running tests
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
------- Additional Comments From rnorwood@redhat.com 2008-01-11 22:36 EST ------- Created an attachment (id=291447) --> (https://bugzilla.redhat.com/attachment.cgi?id=291447&action=view) fix the bind test - NaN doesn't seem to be valid for a double column
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
------- Additional Comments From rnorwood@redhat.com 2008-01-11 22:37 EST ------- Created an attachment (id=291448) --> (https://bugzilla.redhat.com/attachment.cgi?id=291448&action=view) fix io test - but I don't know why it was broken to begin with, so investigation is warrented.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
------- Additional Comments From rnorwood@redhat.com 2008-01-11 22:42 EST ------- Created an attachment (id=291449) --> (https://bugzilla.redhat.com/attachment.cgi?id=291449&action=view) printf formatting is broken for some reason
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
------- Additional Comments From rnorwood@redhat.com 2008-01-11 22:45 EST ------- Created an attachment (id=291450) --> (https://bugzilla.redhat.com/attachment.cgi?id=291450&action=view) the format of this tcl error message changed. the test should be fixed, but I don't know tcl syntax enough to fix it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review-
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
------- Additional Comments From wolfy@nobugconsulting.ro 2008-01-12 17:40 EST ------- Robin, the Fedora-review flag should be set to "-" only if a package has fundamental flaws and the review should deny it. As long as a package is under review, the flag should be "?"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review- |fedora-review?
------- Additional Comments From rnorwood@redhat.com 2008-01-13 11:35 EST ------- Yes, you're right, of course - I fail at following the process. :-)
Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sqlite Alias: sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=226429
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
Michal Nowak mnowak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mnowak@redhat.com Flag| |needinfo?(pmatilai@redhat.c | |om)
--- Comment #11 from Michal Nowak mnowak@redhat.com 2009-04-09 08:56:38 EDT --- Panu, this seems to be stuck for some time due to not reply from package maintainers, can you follow to Robin's proposals & review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
Panu Matilainen pmatilai@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(pmatilai@redhat.c | |om) |
--- Comment #12 from Panu Matilainen pmatilai@redhat.com 2009-04-09 09:02:46 EDT --- Lets just say that it might help somewhat that this bug has been brought to my attention :)
I'll look into this as soon as I've dealt with some other more pressing matters.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
--- Comment #13 from Panu Matilainen pmatilai@redhat.com 2009-05-15 03:40:42 EDT --- Okay, I fixed the rpmlint nitpickery over tab-vs-space etc + obsoletes + the io tests (the difference comes from SQLITE_DISABLE_DIRSYNC build-switch so its ok) in devel. With that, as of sqlite 3.6.14, the test-suite is error-free on ix86 + x86_64, the other testsuite-patches here dont seem to be relevant (at least anymore). Except, hmm, what's with the "use .so instead of .la" patch?
PPC (both 32 and 64bit) is not quite there however, this nan-breakage: http://www.sqlite.org/cvstrac/tktview?tn=3404 and then a pile of rtree-tests fails (possibly due to the nan-issue, haven't looked that closely).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
Michal Nowak mnowak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(robin.norwood@gma | |il.com)
--- Comment #14 from Michal Nowak mnowak@redhat.com 2009-05-15 03:53:17 EDT --- Thanks, Panu!
--
Robin: Can you continue with the review, please? The packages are here: http://koji.fedoraproject.org/koji/packageinfo?packageID=485
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
Robin Norwood robin.norwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(robin.norwood@gma | |il.com) |
--- Comment #15 from Robin Norwood robin.norwood@gmail.com 2009-05-15 12:14:53 EDT --- Yes, I'll get on it. I probably won't be able to get to it until tomorrow, though.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
--- Comment #16 from Robin Norwood robin.norwood@gmail.com 2009-05-17 00:29:52 EDT --- Sorry, one more: rpmlint points out that the -rpath issue is present here. Ref:
https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath
The suggested method using sed to strip out the hardcoded paths seems to work for me at first glance.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
--- Comment #17 from Panu Matilainen pmatilai@redhat.com 2009-06-12 06:50:43 EDT --- rpath is disabled starting with 3.6.14-2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
Michal Nowak mnowak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(robin.norwood@gma | |il.com)
--- Comment #18 from Michal Nowak mnowak@redhat.com 2009-06-12 07:39:28 EDT --- Thanks! So close to review+ :), right?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
Robin Norwood robin.norwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review?, |fedora-review+ |needinfo?(robin.norwood@gma | |il.com) |
--- Comment #19 from Robin Norwood robin.norwood@gmail.com 2009-06-12 11:28:18 EDT --- Yup! Passes review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
Michal Nowak mnowak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #20 from Michal Nowak mnowak@redhat.com 2009-06-13 18:40:07 EDT --- Thanks all.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226429
--- Comment #21 from Panu Matilainen pmatilai@redhat.com 2009-06-15 05:28:52 EDT --- Wohoo :) Thanks.
package-review@lists.fedoraproject.org