https://bugzilla.redhat.com/show_bug.cgi?id=2251101
Bug ID: 2251101 Summary: Review Request: elementary-camera - Camera app designed for elementary Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/elementary-camera.spec SRPM URL: https://decathorpe.fedorapeople.org/elementary-camera-6.2.2-1.fc39.src.rpm
Description: Camera is a simple app to take photos with a webcam.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2251101
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=109417474
https://bugzilla.redhat.com/show_bug.cgi?id=2251101
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/elementa | |ry/camera
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6681037 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2251101
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review+ CC| |ngompa13@gmail.com Status|NEW |POST
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint
Note, it looks like the "mo" locale directories is un-owned and needs to be handled somewhere: /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/mo
This probably needs to be handled in "filesystem".
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2251101
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thank you for the review!
I've added a comment about the unowned directories for "mo" locale to this bug: https://bugzilla.redhat.com/show_bug.cgi?id=2251577
https://bugzilla.redhat.com/show_bug.cgi?id=2251101
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|POST |CLOSED Fixed In Version| |elementary-camera-6.2.2-1.f | |c40 Last Closed| |2023-11-27 15:29:33
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8e0e15bbb4
package-review@lists.fedoraproject.org