https://bugzilla.redhat.com/show_bug.cgi?id=2045079
Bug ID: 2045079 Summary: Review Request: quadlet - opinionated podman runner Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: smooge@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://smooge.fedorapeople.org/automotive_sig_packages/quadlet/SPECS/quadle... SRPM URL: https://smooge.fedorapeople.org/automotive_sig_packages/quadlet/SRPMS/quadle... Description: Quadlet is an opinionated tool for easily running podman system containers under systemd in an optimal way. Fedora Account System Username: ssmoogen
https://bugzilla.redhat.com/show_bug.cgi?id=2045079
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |ngompa13@gmail.com Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2045079
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Initial spec review:
Requires(pre): /usr/sbin/useradd
Your scriptlet has more programs in here, you probably should list them. Alternatively, I believe all the programs are part of shadow-utils, and you can switch to that package name instead.
%_prefix/lib/systemd/system-generators/quadlet-system-generator %_prefix/lib/systemd/user-generators/quadlet-user-generator
Please BuildRequires: systemd-rpm-macros and use the correct macros here:
%{_systemdgeneratordir}/quadlet-system-generator %{_systemdusergeneratordir}/quadlet-user-generator
https://bugzilla.redhat.com/show_bug.cgi?id=2045079
--- Comment #3 from Stephen John Smoogen smooge@redhat.com --- Updated the spec file to https://smooge.fedorapeople.org/automotive_sig_packages/quadlet/SPECS/quadle... and built new sample packages in https://smooge.fedorapeople.org/automotive_sig_packages/quadlet/RPMS/ Please let me know if there are other issues to correct?
https://bugzilla.redhat.com/show_bug.cgi?id=2045079
--- Comment #4 from Neal Gompa ngompa13@gmail.com ---
-- add in buildrequires: shadow-utils
I think you mean Requires(pre) here?
https://bugzilla.redhat.com/show_bug.cgi?id=2045079
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- (In reply to Neal Gompa from comment #4)
-- add in buildrequires: shadow-utils
I think you mean Requires(pre) here?
Or BuildRequires: systemd-rpm-macros instead?
(blech, I wish BZ comments could be edited...)
https://bugzilla.redhat.com/show_bug.cgi?id=2045079
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- Ignoring the changelog entry potential errors...
Review notes:
* Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2045079
--- Comment #7 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/quadlet
package-review@lists.fedoraproject.org