Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request:spice - Implements the SPICE protocol
https://bugzilla.redhat.com/show_bug.cgi?id=613067
Summary: Review Request:spice - Implements the SPICE protocol Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kraxel@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://kraxel.fedorapeople.org/review/spice/spice.spec SRPM URL: http://kraxel.fedorapeople.org/review/spice/spice-0.5.2-1.fc14.src.rpm Description: The Simple Protocol for Independent Computing Environments (SPICE) is a remote display system built for virtual environments which allows you to view a computing 'desktop' environment not only on the machine where it is running, but from anywhere on the Internet and from a wide variety of machine architectures.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
--- Comment #1 from Gerd Hoffmann kraxel@redhat.com 2010-07-09 12:05:54 EDT --- Note that this package depends on celt051 (bug #612979) and spice-protocol (bug #612943).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mclasen@redhat.com AssignedTo|nobody@fedoraproject.org |mclasen@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
--- Comment #2 from Matthias Clasen mclasen@redhat.com 2010-07-09 17:40:35 EDT --- Builds fine in mock. rpmlint output:
rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm spice.src: W: name-repeated-in-summary C SPICE spice-client.x86_64: W: no-manual-page-for-binary spicec 5 packages and 0 specfiles checked; 0 errors, 2 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
--- Comment #3 from Matthias Clasen mclasen@redhat.com 2010-07-09 17:48:51 EDT --- Looking at the license situation:
- the included COPYING is LGPL - the majority of sources seem to say LGPL, some say GPL, and then there's eg server/jpeg_encoder.h which looks BSD - the spec file says GPL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
--- Comment #4 from Matthias Clasen mclasen@redhat.com 2010-07-09 19:10:25 EDT --- package name: ok spec file name: ok packaging guidelines: small cleanups are possible if the package is only for F13+: - remove BuildRoot - remove initial rm -rf in %install - ditch %clean things that need fixing: - ExclusiveArch: should have a comment explaining why the package only works on some arches and ideally a bug ref. See https://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failu... - the CFLAGS munging needs justification in a comment. Why remove -Wall ? and in particular, why remove _FORTIFY_SOURCE ? See https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags - if libspice-server.a must be packaged, it needs to go into a -static subpackage. See https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Librari... license: ok license field/license file: see previous comment spec file language: ok spec file readable: ok buildable: ok ExcludeArch: see above BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok file permissions: ok. (pedants prefer the 4-argument form of %defattr) macro use: ok permissable content: ok large docs: ok %doc content: ok headers: ok shared libs: ok static libs: see above devel deps: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
--- Comment #5 from Gerd Hoffmann kraxel@redhat.com 2010-07-12 03:31:37 EDT --- Created bug #613529 for the portability issues which make spice x86 only.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
--- Comment #6 from Gerd Hoffmann kraxel@redhat.com 2010-07-12 05:48:40 EDT --- Updated packages + specfile uploaded to http://kraxel.fedorapeople.org/review/spice/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #7 from Matthias Clasen mclasen@redhat.com 2010-07-12 10:37:39 EDT --- Setting CFLAGS as you do now is probably a nop, looking at the definition of %configure:
%configure \ CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ; \ CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS ; \ ...
but that is not a big deal. The rest looks fine now. Approved
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
Gerd Hoffmann kraxel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Gerd Hoffmann kraxel@redhat.com 2010-07-12 11:07:47 EDT --- New Package CVS Request ======================= Package Name: spice Short Description: Implements the SPICE protocol Owners: kraxel alexl Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2010-07-12 13:26:53 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
Chen Lei supercyper1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper1@gmail.com
--- Comment #10 from Chen Lei supercyper1@gmail.com 2010-07-13 05:23:25 EDT --- %changelog
* Mon Jul 12 2010 Gerd Hoffmann kraxel@redhat.com - 0.5.2-3
- %configure handles CFLAGS automatically, no need to fiddle
with %{optflags} manually.
should be changed to
* Mon Jul 12 2010 Gerd Hoffmann kraxel@redhat.com - 0.5.2-3
- %%configure handles CFLAGS automatically, no need to fiddle
with %%{optflags} manually.
See http://koji.fedoraproject.org/koji/buildinfo?buildID=183372
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=613067
Gerd Hoffmann kraxel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
--- Comment #11 from Gerd Hoffmann kraxel@redhat.com 2010-07-13 08:39:07 EDT --- rawhide builds are done.
package-review@lists.fedoraproject.org