Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libwacom - Tablet Information Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=768800
Summary: Review Request: libwacom - Tablet Information Client Library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: peter.hutterer@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://people.freedesktop.org/~whot/libwacom/libwacom.spec SRPM URL: http://people.freedesktop.org/~whot/libwacom/libwacom-0.1-1.fc16.src.rpm Description: libwacom is a library that provides information about Wacom tablets and tools. This information can then be used by drivers or applications to tweak the UI or general settings to match the physical tablet.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mclasen@redhat.com QAContact|extras-qa@fedoraproject.org |mclasen@redhat.com
--- Comment #1 from Matthias Clasen mclasen@redhat.com 2011-12-21 10:39:34 EST --- builds fine in mock, rpmlint says:
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm 5 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
--- Comment #2 from Matthias Clasen mclasen@redhat.com 2011-12-21 10:51:43 EST --- package name: ok spec file name: ok packaging guidelines: generally, ok. some minor cleanups possible: - BuildRoot: is no longer needed - rm -rf %{buildroot} in %install no longer needed - %clean no longer needed fine to leave these things in place if you want to minimize spec file changes for building on e.g. RHEL license: ok license: field ok license file: ok spec language: ok spec readable: ok upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libs: ok relocatable: ok directory ownership: looks like you need to own %{_datadir}/libwacom %{_includedir}/libwacom-1.0 %{_includedir}/libwacom-1.0/libwacom duplicate files: ok file permissions: ok macro use: ok content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel dep: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok
Summary: fix directory ownership, then it is good to go
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
--- Comment #3 from Peter Hutterer peter.hutterer@redhat.com 2011-12-21 21:46:24 EST --- (In reply to comment #2)
packaging guidelines: generally, ok. some minor cleanups possible:
- BuildRoot: is no longer needed
- rm -rf %{buildroot} in %install no longer needed
- %clean no longer needed
all three removed
directory ownership: looks like you need to own %{_datadir}/libwacom %{_includedir}/libwacom-1.0 %{_includedir}/libwacom-1.0/libwacom
added to the devel/data packages as required. update spec/srpm available at URL above
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #4 from Matthias Clasen mclasen@redhat.com 2011-12-21 22:47:11 EST --- Looks all good now. Approved
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
Peter Hutterer peter.hutterer@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Peter Hutterer peter.hutterer@redhat.com 2011-12-21 22:54:15 EST --- New Package SCM Request ======================= Package Name: libwacom Short Description: Tablet Information Client Library Owners: whot hadess Branches: f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
--- Comment #6 from Jon Ciesla limburgher@gmail.com 2011-12-22 08:23:02 EST --- Git done (by process-git-requests).
Matthias, please take ownership of review BZs. Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-12-23 02:45:59 EST --- libwacom-0.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libwacom-0.1-1.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
Peter Hutterer peter.hutterer@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2011-12-23 02:58:17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
Bastien Nocera bnocera@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mclasen@redhat.com QAContact|mclasen@redhat.com |extras-qa@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768800
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |libwacom-0.1-1.fc16 Resolution|NEXTRELEASE |ERRATA
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2012-01-11 01:10:19 EST --- libwacom-0.1-1.fc16 has been pushed to the Fedora 16 stable repository.
package-review@lists.fedoraproject.org