Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
Summary: Review Request: glump - A small web application to glue files from multiple sources Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jeff@ocjtech.us QAContact: fedora-package-review@redhat.com
Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-1.fc6.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-1.fc6.src.rpm Description:
Glump is a simple web application that glues files from various pieces, based on the hostname that makes the request. This is useful for large installations that want to send different files to different hosts.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
------- Additional Comments From yaneti@declera.com 2006-12-07 17:19 EST ------- Forbidden
You don't have permission to access /misc/fedora/6/SRPMS/glump-0.9.11-1.fc6.spec on this server.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
------- Additional Comments From jeff@ocjtech.us 2006-12-07 17:24 EST ------- (In reply to comment #1)
You don't have permission to access /misc/fedora/6/SRPMS/glump-0.9.11-1.fc6.spec on this server.
Whoops! Fixed...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-12-19 13:41 EST ------- I cannot see your spec/srpm as access seems forbidden...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
------- Additional Comments From jeff@ocjtech.us 2006-12-19 14:07 EST ------- (In reply to comment #3)
I cannot see your spec/srpm as access seems forbidden...
The spec file that was stored in the SRPM didn't have world read permissions set, so when my script that I use to publish SRPMS to my web server extracted the specfile it overwrote the permissions. I've updated the SRPM with a spec file that has the proper permissions.
Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-2.fc6.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-2.fc6.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED OtherBugsDependingO|163776 | nThis| | AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
------- Additional Comments From tibbs@math.uh.edu 2007-06-09 20:30 EST ------- Amazing that nobody's looked at this yet; it seems a simple enough package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mmahut@redhat.com
------- Additional Comments From mmahut@redhat.com 2007-06-09 20:54 EST ------- 1) I noticed and it's making rpmlint sad too, that you are not using correct tab spaces in your spec file.
2) Your %install must have a "cleaning" buildroot section, I recommend you start with:
%install rm -rf %{buildroot}
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
------- Additional Comments From jeff@ocjtech.us 2007-06-09 21:59 EST ------- Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-3.fc6.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-3.fc6.src.rpm
I've updated the package to reflect Marek's comments.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
------- Additional Comments From tibbs@math.uh.edu 2007-06-09 22:14 EST ------- Crap, I was typing this up but had to break for dinner before I could submit it. Here's what I wrote:
rpmlint output is OK:
W: glump mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13) Not a blocker; fix it if you wish.
E: glump explicit-lib-dependency libxml2-python This is a false positive. The package is necessary, and the dependency generator doesn't find it automatically.
Marek is right; you should clean the buildroot at the beginning of install. Usually rpmlint complains about that; I'm not sure why it didn't.
* source files match upstream: 634325e4efb057c5b849bf831a51ce8e7e11cec572b6769e9645f06443ae51ab glump-0.9.11.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint has only acceptable complaints. * final provides and requires are sane: config(glump) = 0.9.11-2.fc8 glump = 0.9.11-2.fc8 = /usr/bin/python config(glump) = 0.9.11-2.fc8 httpd libxml2-python mod_python * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs@math.uh.edu 2007-06-09 22:17 EST ------- And now looking at the -3 package, I see you fixed everything I had an issue with, so we're ready to go.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
------- Additional Comments From jeff@ocjtech.us 2007-06-09 22:21 EST ------- New Package CVS Request ======================= Package Name: glump Short Description: A small web application to glue files from multiple sources Owners: jeff@ocjtech.us Branches: devel F-7 FC-6 EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
jeff@ocjtech.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From jeff@ocjtech.us 2007-06-09 22:22 EST ------- Gahhh... hit "save changes" too soon...
Jason... thanks for the review! You guys are really rockin' on the reviews...
New Package CVS Request ======================= Package Name: glump Short Description: A small web application to glue files from multiple sources Owners: jeff@ocjtech.us Branches: devel F-7 FC-6 EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From tibbs@math.uh.edu 2007-06-09 22:27 EST ------- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glump - A small web application to glue files from multiple sources
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577
jeff@ocjtech.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From jeff@ocjtech.us 2007-06-11 00:42 EST ------- Thanks everyone!
package-review@lists.fedoraproject.org