https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Bug ID: 2087174 Summary: Review Request: Telepathy-idle - IRC connection manager for Telepathy Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: ali.erdinc.koroglu@intel.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-r... SRPM URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-r...
Description: IRC connection manager for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Ali Erdinc Koroglu ali.erdinc.koroglu@intel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Ali Erdinc Koroglu ali.erdinc.koroglu@intel.com --- This package is runtime dependency for Polari (#2064643). After the reviewing process I'll open unretire request in pagure.
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2064643
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2064643 [Bug 2064643] F37FailsToInstall: polari
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@fedoraproject.org
--- Comment #2 from Mamoru TASAKA mtasaka@fedoraproject.org --- So as I happen to be telepathy-glib maintainer, I comment for now.
* Now for new packages License field must use SPDX identifier:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline... https://spdx.org/licenses/
* For BuildRequires: using "BuildRequires: pkgconfig(foo)" is preferred than to use "BuildRequires: dbus-glib-devel" or so
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequ...
* Unneeded BR - At least "BR: openssl-devel" seems unneeded - Also check if there is any more unneeded BRs left.
* Using "python-unversioned-command" as BR is strongly discouraged. Patch out not to use non-version python and use python3.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependenc...
* scratch build says: checking for Python with Twisted and IRC protocol support... no https://koji.fedoraproject.org/koji/taskinfo?taskID=91402714 Looking at configure.ac, this perhaps means that some twisted tests are disabled. Please consider to enable this.
* Directory ownership: https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories... With "mock --init" and doint "mock --install telepathy-idle.x86_64.rpm", /usr/share/dbus-1/services/ is not owned by any packages. ============================================================= [mockbuild@93f3667e0cdb434cb87064920e66e928 ~]$ rpm -qf /usr/share/dbus-1/services/ file /usr/share/dbus-1/services is not owned by any package ============================================================= Make it sure this directory is owned by some package when telepathy-idle is installed.
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |Telepathy-idle - IRC |telepathy-idle - IRC |connection manager for |connection manager for |Telepathy |Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
--- Comment #3 from Mamoru TASAKA mtasaka@fedoraproject.org --- Some notes:
* For BR: pkgconfig(foo), you can check for configure.ac, and check what is used with PKG_CHECK_MODULES macro or so.
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ali.erdinc.korogl | |u@intel.com) Whiteboard| |AwaitingSubmitter
--- Comment #4 from Mamoru TASAKA mtasaka@fedoraproject.org --- Setting NEEDINFO.
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Ali Erdinc Koroglu ali.erdinc.koroglu@intel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ali.erdinc.korogl | |u@intel.com) |
--- Comment #5 from Ali Erdinc Koroglu ali.erdinc.koroglu@intel.com --- I've taken as is from F36 but I updated the spec as you recommended
Spec URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-r... SRPM URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-r...
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Whiteboard|AwaitingSubmitter | Assignee|nobody@fedoraproject.org |mtasaka@fedoraproject.org
--- Comment #6 from Mamoru TASAKA mtasaka@fedoraproject.org --- Assigning.
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
--- Comment #7 from Mamoru TASAKA mtasaka@fedoraproject.org --- * License - Many files (such as src/idle-connection-manager.c or so) explictly says the license is under LGPL-2.0 only. Please check this.
* Directory ownership issue - /usr/share/dbus-1/ and /usr/share/dbus-1/services/ are unowned by any packages when telepathy-idle binary is installed. Add: "Requires: dbus-common".
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
--- Comment #8 from Ali Erdinc Koroglu ali.erdinc.koroglu@intel.com --- I checked the code so license is LGPL-2.1-or-later and as you're saying /usr/share/dbus-1/services belongs to dbus-common which is added as "requires"
SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-r... SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-r...
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
--- Comment #9 from Mamoru TASAKA mtasaka@fedoraproject.org --- * License - For example, this https://gitlab.freedesktop.org/telepathy/telepathy-idle/-/blob/master/src/id... says "GNU Lesser General Public License version 2.1 as published", this is LGPL-2.1 only.
For reference, this sentence https://gitlab.freedesktop.org/telepathy/telepathy-idle/-/blob/master/extens... is LGPL-2.1-or-later .
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
--- Comment #10 from Ali Erdinc Koroglu ali.erdinc.koroglu@intel.com --- Project's license (https://gitlab.freedesktop.org/telepathy/telepathy-idle/-/blob/master/COPYIN...) is LGPL-2.1-or-later, probably they forgot to change that while migrating from SF.net to SVN 15 years ago :)
But we can do like "LGPL-2.1-only AND LGPL-2.1-or-later"
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
--- Comment #11 from Mamoru TASAKA mtasaka@fedoraproject.org --- We judge the license of the software not only from copyright files but also the actual contents of the source file. Please change the license tag to "LGPL-2.1-only AND LGPL-2.1-or-later".
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
--- Comment #12 from Ali Erdinc Koroglu ali.erdinc.koroglu@intel.com --- Sure, license is changed as requested
SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-r... SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-r...
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #13 from Mamoru TASAKA mtasaka@fedoraproject.org --- * Name legitimate * EVR correct * License correct * Summary clean * Source matches upstream * BR / Requires okay * %prep / %build / %install / %check okay * %files okay * rpmlint on srpm clean * directory ownership okay
* scratch build okay https://koji.fedoraproject.org/koji/taskinfo?taskID=91904425 * build logs are sane * %optflags correctly used * can be installed * rpmlint on binary rpm okay
Approving.
================================================== This package (telepathy-idle) is APPROVED by mtasaka ==================================================
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Ali Erdinc Koroglu ali.erdinc.koroglu@intel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ASSIGNED |CLOSED Last Closed| |2022-09-15 06:09:28
--- Comment #14 from Ali Erdinc Koroglu ali.erdinc.koroglu@intel.com --- Thank you Mamoru
https://koji.fedoraproject.org/koji/buildinfo?buildID=2062783
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
--- Comment #15 from Mamoru TASAKA mtasaka@fedoraproject.org --- Please rebuild this package also on F-37, and submit to bodhi (submitting to bodhi is needed for F-37) - unless this, polari dependency issue on F-37 cannot be resolved.
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Ali Erdinc Koroglu aekoroglu@linux.intel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aekoroglu@linux.intel.com
--- Comment #16 from Ali Erdinc Koroglu aekoroglu@linux.intel.com --- Yep I did, thanks
https://bodhi.fedoraproject.org/updates/FEDORA-2022-d23557aec2
package-review@lists.fedoraproject.org