https://bugzilla.redhat.com/show_bug.cgi?id=1400626
Bug ID: 1400626 Summary: Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/a919440819bc623cd41523... SRPM URL: http://rpms.remirepo.net/SRPMS/php-gecko-packages-gecko-php-unit-2.0.0-1.rem... Description: Provides additional asserts to be used in PHPUnit tests. The asserts are provided using Traits so no changes are needed in the hierarchy of test classes.
Autoloader: /usr/share/php/GeckoPackages/PHPUnit/autoload.php
Fedora Account System Username: remi
-- New dependency of php-cs-fixer v2 As usually, I will clean the EL-5/remirepo stuff after import (to avoid having to maintain 2 spec)
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |shawn@iwin.ski Assignee|nobody@fedoraproject.org |shawn@iwin.ski Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #1 from Shawn Iwinski shawn@iwin.ski --- Created attachment 1227327 --> https://bugzilla.redhat.com/attachment.cgi?id=1227327&action=edit phpcompatinfo-full.log
phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #2 from Shawn Iwinski shawn@iwin.ski --- Created attachment 1227328 --> https://bugzilla.redhat.com/attachment.cgi?id=1227328&action=edit phpcompatinfo-lib.log
phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #3 from Shawn Iwinski shawn@iwin.ski --- Created attachment 1227329 --> https://bugzilla.redhat.com/attachment.cgi?id=1227329&action=edit fedora-review.txt
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1400626 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Shawn Iwinski shawn@iwin.ski --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required
As usual, remove EPEL 5 bits after initial import.
No blockers.
===== APPROVED =====
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Thanks for the review.
SCM requested.
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-gecko-packages-gecko-...
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- php-gecko-packages-gecko-php-unit-2.0.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-745efbc9da
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- php-gecko-packages-gecko-php-unit-2.0.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5b842fcf20
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-gecko-packages-gecko-php-unit-2.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3d92223be1
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-gecko-packages-gecko-php-unit-2.0.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5b842fcf20
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-gecko-packages-gecko-php-unit-2.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3d92223be1
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-gecko-packages-gecko-php-unit-2.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-745efbc9da
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-12-10 19:29:09
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-gecko-packages-gecko-php-unit-2.0.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-gecko-packages-gecko-php-unit-2.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-gecko-packages-gecko-php-unit-2.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org