https://bugzilla.redhat.com/show_bug.cgi?id=968856
Bug ID: 968856 Summary: Review Request: nodejs-jsonify - JSON without touching any globals Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jamielinux@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://jamielinux.fedorapeople.org/tape/nodejs-jsonify.spec SRPM URL: http://jamielinux.fedorapeople.org/tape/SRPMS/nodejs-jsonify-0.0.0-1.fc19.sr... Fedora Account System Username: jamielinux
Description: JSON without touching any globals.
https://bugzilla.redhat.com/show_bug.cgi?id=968856
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews), | |968857
https://bugzilla.redhat.com/show_bug.cgi?id=968856
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tchollingsworth@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=968856
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #1 from T.C. Hollingsworth tchollingsworth@gmail.com ---
Package Review ==============
Legend: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed
Status: APPROVED
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8.
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. OK, missing deps [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-jsonify-0.0.0-1.fc20.noarch.rpm nodejs-jsonify.noarch: W: spelling-error Summary(en_US) globals -> global, global s nodejs-jsonify.noarch: W: spelling-error %description -l en_US globals -> global, global s nodejs-jsonify.noarch: W: spelling-error %description -l en_US stringify -> stringy nodejs-jsonify.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
OK
Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-jsonify nodejs-jsonify.noarch: W: spelling-error Summary(en_US) globals -> global, global s nodejs-jsonify.noarch: W: spelling-error %description -l en_US globals -> global, global s nodejs-jsonify.noarch: W: spelling-error %description -l en_US stringify -> stringy nodejs-jsonify.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:'
OK
Requires -------- nodejs-jsonify (rpmlib, GLIBC filtered): nodejs(engine)
OK
Provides -------- nodejs-jsonify: nodejs-jsonify npm(jsonify)
OK
Source checksums ---------------- http://registry.npmjs.org/jsonify/-/jsonify-0.0.0.tgz : CHECKSUM(SHA256) this package : 030f926cb3d18933c9bce7fe3d1dddbde73b91532dc4cada98214337e811c89c CHECKSUM(SHA256) upstream package : 030f926cb3d18933c9bce7fe3d1dddbde73b91532dc4cada98214337e811c89c
OK
Generated by fedora-review 0.4.0 (eaf16cd) last change: 2013-05-30 Buildroot used: fedora-rawhide-vanilla-x86_64 Command line :./try-fedora-review -b968856
https://bugzilla.redhat.com/show_bug.cgi?id=968856
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Jamie Nguyen jamielinux@fedoraproject.org --- New Package SCM Request ======================= Package Name: nodejs-jsonify Short Description: JSON without touching any globals Owners: jamielinux patches Branches: f18 f19 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=968856
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=968856
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=968856
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=968856
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- nodejs-jsonify-0.0.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-jsonify-0.0.0-1.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=968856
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nodejs-jsonify-0.0.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-jsonify-0.0.0-1.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=968856
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- nodejs-jsonify-0.0.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-jsonify-0.0.0-1.el6
https://bugzilla.redhat.com/show_bug.cgi?id=968856
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2013-05-30 10:42:51
https://bugzilla.redhat.com/show_bug.cgi?id=968856
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |nodejs-jsonify-0.0.0-1.fc19 Resolution|RAWHIDE |ERRATA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-jsonify-0.0.0-1.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=968856
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-jsonify-0.0.0-1.fc19 |nodejs-jsonify-0.0.0-1.fc18
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nodejs-jsonify-0.0.0-1.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=968856
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-jsonify-0.0.0-1.fc18 |nodejs-jsonify-0.0.0-1.el6
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-jsonify-0.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org