https://bugzilla.redhat.com/show_bug.cgi?id=1190510
Bug ID: 1190510 Summary: Review Request: <main package name here> - <short summary here> Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: herculesoplimpus@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://mayorga.fedorapeople.org/gitshelf.spec SRPM URL: https://mayorga.fedorapeople.org/gitshelf-0.0.4-1.fc20.src.rpm
Description: gitshelf - a shelf full of git repos.
Manage a collection of git repos that, you don't want to manage as sub-modules.
Created to be used to manage a set of salt states, formula & pillars in a controlled fashion, the default config file is a YAML file that can also be loaded as a pillar (for whatever reason). Using the branch parameter, you can pin a repo to a branch, sha1, tag, whatever you need ...
Fedora Account System Username:espasmo
https://bugzilla.redhat.com/show_bug.cgi?id=1190510
Fernando herculesoplimpus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <main |Review Request: gitshelf - |package name here> - <short |Manage a shelf full of git |summary here> |repos
https://bugzilla.redhat.com/show_bug.cgi?id=1190510
Carlos Morel-Riquelme empateinfinito@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |empateinfinito@gmail.com
--- Comment #1 from Carlos Morel-Riquelme empateinfinito@gmail.com --- Hi Fernado, this is a informal review. well you have some warnings in the spec file.
rpmlint Checking: gitshelf-0.0.4-1.fc22.noarch.rpm gitshelf-0.0.4-1.fc22.src.rpm gitshelf.noarch: W: spelling-error Summary(en_US) repos -> ropes, reps, repose gitshelf.noarch: W: spelling-error %description -l en_US repos -> ropes, reps, repose gitshelf.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure gitshelf.noarch: W: spelling-error %description -l en_US repo -> rope, rep, reps gitshelf.noarch: W: invalid-license ASL 2 gitshelf.noarch: W: no-manual-page-for-binary gitshelf gitshelf.src: W: spelling-error Summary(en_US) repos -> ropes, reps, repose gitshelf.src: W: spelling-error %description -l en_US repos -> ropes, reps, repose gitshelf.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure gitshelf.src: W: spelling-error %description -l en_US repo -> rope, rep, reps gitshelf.src: W: invalid-license ASL 2 2 packages and 0 specfiles checked; 0 errors, 11 warnings.
-------------------------------------------------------------------------------
1) w: invalid-license ASL 2 - the correct way is "ASL 2.0" - please see the wiki https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Package_Licensing...
2) w: spelling-error - please change "repo" to "repository" - please change "config" to "configure"
3) w: no-manual-page-for-binary - pass this.
4) update this - release version to "2" - change version in your changelog
------------------------------------------------------------------------------
finally your spec file should look this
%global pypi_name gitshelf
Name: gitshelf Version: 0.0.4 Release: 2%{?dist} Summary: Manage a shelf full of git repositories
License: ASL 2.0 URL: https://github.com/gitshelf/gitshelf Source0: https://pypi.python.org/packages/source/g/%%7Bpypi_name%7D/%%7Bpypi_name%7D-... BuildArch: noarch
BuildRequires: python-devel BuildRequires: python-setuptools
%description gitshelf - a shelf full of git repositories.
Manage a collection of git repository that, you don't want to manage as sub-modules.
Created to be used to manage a set of salt states, formula & pillars in a controlled fashion, the default configuration file is a YAML file it's can also be loaded as a pillar (for whatever reason). Using the branch parameter, you can pin a repository to a branch, sha1, tag, whatever you need ...
%prep %setup -q -n %{pypi_name}-%{version} # Remove bundled egg-info rm -rf %{pypi_name}.egg-info
%build %{__python2} setup.py build
%install %{__python2} setup.py install --skip-build --root %{buildroot}
%files %doc README.md %{_bindir}/* %{python2_sitelib}/%{pypi_name} %{python2_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info
%changelog * Mon Feb 9 2015 Fernando Espinoza espasmo@fedoraproject.org - 0.0.4-2
* Sun Feb 8 2015 Fernando Espinoza espasmo@fedoraproject.org - 0.0.4-3 - Initial Packaging
------------------------------------------------------------------------------
https://bugzilla.redhat.com/show_bug.cgi?id=1190510
Eduardo Mayorga e@mayorgalinux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |e@mayorgalinux.com Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1190510
--- Comment #2 from Eduardo Mayorga e@mayorgalinux.com --- Any progress here?
https://bugzilla.redhat.com/show_bug.cgi?id=1190510
Eduardo Mayorga e@mayorgalinux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |herculesoplimpus@gmail.com Flags| |needinfo?(herculesoplimpus@ | |gmail.com)
--- Comment #3 from Eduardo Mayorga e@mayorgalinux.com --- Are you still interested in this review? If so, please comment in this ticket within one week, otherwise I'll close it as per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_....
https://bugzilla.redhat.com/show_bug.cgi?id=1190510
Eduardo Mayorga e@mayorgalinux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Flags|needinfo?(herculesoplimpus@ | |gmail.com) | Last Closed| |2015-09-15 13:53:50
--- Comment #4 from Eduardo Mayorga e@mayorgalinux.com --- It's been a week so I'm closing this bug. Feel free to submit a new review request if you are interested again.
https://bugzilla.redhat.com/show_bug.cgi?id=1190510
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org