https://bugzilla.redhat.com/show_bug.cgi?id=863437
Bug ID: 863437 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: webrtc-audio-processing - echo cancellation for Pulse Audio Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: cschalle@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://uraeus.fedorapeople.org/rpm-staging/webrtc-audio-processing.spec SRPM URL: http://uraeus.fedorapeople.org/rpm-staging/webrtc-audio-processing-0.1-1.fc1... Description: This containts the webrtc echo cancellation module released by Google. It has been cleaned up and packaged as a library for use by among others Pulse Audio. Fedora Account System Username:uraeus
https://bugzilla.redhat.com/show_bug.cgi?id=863437
--- Comment #1 from Christian Fredrik Kalager Schaller cschalle@redhat.com --- Thought I should also link to the upstream project: http://www.freedesktop.org/software/pulseaudio/webrtc-audio-processing/
https://bugzilla.redhat.com/show_bug.cgi?id=863437
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |yaneti@declera.com Assignee|nobody@fedoraproject.org |yaneti@declera.com Flags| |fedora-review+
--- Comment #2 from Yanko Kaneti yaneti@declera.com --- ...reviewing the updated spec which doesn't match the SRPM because the srpm wasn't updated...
License matches. Source matches upstream. Name seems reasonable. Doesn't conflict with anything existing. Library versioned reasonably. Include files unique and separate enough.
- You should add the PATENTS files to %doc - There is a stray "i" on the first description line, please remove
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=863437
--- Comment #3 from Yanko Kaneti yaneti@declera.com --- Builds in mock. rpmmlint.. webrtc-audio-processing.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/webrtc-audio-processing-0.1/AUTHORS webrtc-audio-processing-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. ..harmless
https://bugzilla.redhat.com/show_bug.cgi?id=863437
--- Comment #4 from Christian Fredrik Kalager Schaller cschalle@redhat.com --- ok, two suggested fixes included. Will proceed with getting this packaged during the weekend. Thanks for the quick review.
https://bugzilla.redhat.com/show_bug.cgi?id=863437
Christian Fredrik Kalager Schaller cschalle@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Christian Fredrik Kalager Schaller cschalle@redhat.com --- New Package SCM Request ======================= Package Name: webrtc-audio-processing Short Description: Echo cancellation module for PulseAudio and others Owners: uraeus, rishi Branches: f17,f18 InitialCC: bpebble, rdieter
https://bugzilla.redhat.com/show_bug.cgi?id=863437
--- Comment #6 from Christian Fredrik Kalager Schaller cschalle@redhat.com --- Updated SRPM to match current spec file
https://bugzilla.redhat.com/show_bug.cgi?id=863437
--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu --- "bpebble" is not a valid account name.
https://bugzilla.redhat.com/show_bug.cgi?id=863437
Christian Fredrik Kalager Schaller cschalle@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from Christian Fredrik Kalager Schaller cschalle@redhat.com --- No matter, Brian can add himself later on. Please go ahead and create the module without him on the cc list.
https://bugzilla.redhat.com/show_bug.cgi?id=863437
--- Comment #9 from Yanko Kaneti yaneti@declera.com --- New Package SCM Request ======================= Package Name: webrtc-audio-processing Short Description: Echo cancellation module for PulseAudio and others Owners: uraeus rishi Branches: f17 f18 InitialCC: bpepple rdieter
https://bugzilla.redhat.com/show_bug.cgi?id=863437
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=863437
Debarshi Ray debarshir@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED CC| |debarshir@redhat.com Resolution|--- |NEXTRELEASE Flags|fedora-cvs+ | Flags| |fedora-cvs? Last Closed| |2012-10-09 11:57:44
https://bugzilla.redhat.com/show_bug.cgi?id=863437
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Already done.
package-review@lists.fedoraproject.org