Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
Bug ID: 880882 Summary: Review Request: php-JsonSchema - PHP implementation of JSON schema Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: shawn.iwinski@gmail.com
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-JsonSchema.spec
SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-JsonSchema-1.2.1-1.fc17....
Description: A PHP implementation for validating JSON structures against a given schema.
See http://json-schema.org for more details.
Fedora Account System Username: siwinski
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |php-JsonSchema
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #1 from Shawn Iwinski shawn.iwinski@gmail.com --- NOTE: Tests not included or run because Composer (http://getcomposer.org/) required
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #2 from Remi Collet fedora@famillecollet.com --- You can simply run the tests using a trivial PSR0 autoload.php
<?php spl_autoload_register(function ($class) { $src = str_replace('\', '/', $class).'.php'; require_once $src; });
And phpunit --bootstrap=autoload.php -d include_path="../src/:.:/usr/share/pear" .
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #3 from Shawn Iwinski shawn.iwinski@gmail.com --- (In reply to comment #2)
Thanks for the tip. Tests are now run in %check.
Changelog: - Updated to upstream version 1.2.2 - Added php-ctype require - Added PSR-0 autoloader for tests - Added %check
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-JsonSchema.spec
SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-JsonSchema-1.2.2-1.fc17....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #4 from Shawn Iwinski shawn.iwinski@gmail.com --- Sorry. Build failure in Koji. Will fix soon.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #5 from Shawn Iwinski shawn.iwinski@gmail.com --- Changelog: - Fixed failing Mock/Koji builds - Removed "docs" directory from %doc
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-JsonSchema.spec
SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-JsonSchema-1.2.2-2.fc17....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Created attachment 663620 --> https://bugzilla.redhat.com/attachment.cgi?id=663620&action=edit phpci-src.log
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #7 from Remi Collet fedora@famillecollet.com --- Created attachment 663622 --> https://bugzilla.redhat.com/attachment.cgi?id=663622&action=edit phpci-tests.log
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #8 from Remi Collet fedora@famillecollet.com --- Created attachment 663624 --> https://bugzilla.redhat.com/attachment.cgi?id=663624&action=edit php-JsonSchema-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 880882
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #9 from Remi Collet fedora@famillecollet.com --- All seems fine. No blocker.
=== APPROVED ===
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #10 from Shawn Iwinski shawn.iwinski@gmail.com --- THANKS for the review and tips!
New Package SCM Request ======================= Package Name: php-JsonSchema Short Description: PHP implementation of JSON schema Owners: siwinski Branches: f17 f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-JsonSchema-1.2.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-JsonSchema-1.2.2-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-JsonSchema-1.2.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-JsonSchema-1.2.2-2.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-JsonSchema-1.2.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-JsonSchema-1.2.2-2.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-JsonSchema-1.2.2-2.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2012-12-25 23:58:27
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-JsonSchema-1.2.2-2.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-JsonSchema-1.2.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880882
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-JsonSchema-1.2.2-2.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org