Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-linode - Ruby wrapper for the Linode API
https://bugzilla.redhat.com/show_bug.cgi?id=633549
Summary: Review Request: rubygem-linode - Ruby wrapper for the Linode API Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mastahnke@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://stahnma.fedorapeople.org/reviews/rubygem-linode.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/rubygem-linode-0.6.2-1.fc15.src.rpm Description: This is a wrapper around Linode's automation facilities.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-16 18:16:12 EDT --- I will take this package. Instead I will appreciate it if you would review my review request (bug 634759)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #2 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-17 13:38:25 EDT --- For 0.6.2-1:
* Dependency - Writing ">= 0.4.4" on "(Build)Requires: rubygem(httparty)" is not needed https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
- If you use "BuildRequires(check)" syntax, I guess "rubygem(mocha)" "rubygem(httparty)" are needed only for %check so using "BR(check)" is apppropriate ! Note that rubygem(httparty) is also needed for Requires, as you already wrote so.
* %{geminstdir}/linode.gemspec - Would you check if this is really needed?
* %doc attribute in -doc subpackage - I think writing %doc attribute in -doc subpackage is redundant because the name of the rpm already indicates that the rpm is for documentation.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #3 from Michael Stahnke mastahnke@gmail.com 2010-09-17 14:27:12 EDT --- Fixed all issues.
http://stahnma.fedorapeople.org/reviews/rubygem-linode-0.6.2-2.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-18 13:11:54 EDT --- Well,
- So would you check if %{geminstdir}/linode.gemspec is needed? (i.e. I think this file is not needed). Note that gemspec file is also installed under %gemdir/specifications/
* BR(check): rubygem(httparty) is written twice.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #5 from Michael Stahnke mastahnke@gmail.com 2010-09-21 21:11:45 EDT --- Sorry, I thought I had fixed those issues. I was working on two different systems and uploaded the incorrect one. Fixed, and bumped.
http://stahnma.fedorapeople.org/reviews/rubygem-linode-0.6.2-3.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #6 from Michael Stahnke mastahnke@gmail.com 2010-09-21 21:13:19 EDT --- According to http://code.google.com/p/ruby-ole/ it is GPLv2. Should I file a bug with upstream to include that in the file package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-22 14:14:10 EDT --- (In reply to comment #6)
According to http://code.google.com/p/ruby-ole/ it is GPLv2. Should I file a bug with upstream to include that in the file package?
(note that this comment is for bug 634608 (rubygem-ruby-ole) )
Okay. --------------------------------------------------------------- This package (rubygem-linode) is APPROVED by mtasaka ---------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
Michael Stahnke mastahnke@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Michael Stahnke mastahnke@gmail.com 2010-09-22 16:19:36 EDT --- New Package SCM Request ======================= Package Name: rubygem-linnode Short Description: Ruby wrapper for the linode API Owners: stahnma Branches: F13 F14 EL5 EL6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #9 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-23 02:03:48 EDT --- (In reply to comment #8)
New Package SCM Request
Package Name: rubygem-linnode Short Description: Ruby wrapper for the linode API Owners: stahnma Branches: F13 F14 EL5 EL6 InitialCC:
Would you recheck "Package Name"?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #10 from Michael Stahnke mastahnke@gmail.com 2010-09-23 10:08:04 EDT --- New Package SCM Request ======================= Package Name: rubygem-linode Short Description: Ruby wrapper for the linode API Owners: stahnma Branches: F13 F14 EL5 EL6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #11 from Kevin Fenzi kevin@tummy.com 2010-09-25 01:00:37 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-09-25 22:14:13 EDT --- rubygem-linode-0.6.2-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-linode-0.6.2-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-09-25 22:14:20 EDT --- rubygem-linode-0.6.2-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-linode-0.6.2-1.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-09-26 23:38:55 EDT --- rubygem-linode-0.6.2-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-linode'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-linode-0.6.2-1.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |NEXTRELEASE Last Closed| |2010-10-03 13:41:36
--- Comment #15 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-03 13:41:36 EDT --- Closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-10-05 09:11:55 EDT --- rubygem-linode-0.6.2-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |rubygem-linode-0.6.2-1.fc14 Resolution|NEXTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2010-10-08 16:37:21 EDT --- rubygem-linode-0.6.2-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633549
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|rubygem-linode-0.6.2-1.fc14 |rubygem-linode-0.6.2-1.fc13
package-review@lists.fedoraproject.org