Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-isolate - Very simple RubyGems sandbox
https://bugzilla.redhat.com/show_bug.cgi?id=657591
Summary: Review Request: rubygem-isolate - Very simple RubyGems sandbox Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mtasaka@ioa.s.u-tokyo.ac.jp QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-isolate/rubygem-isola... SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-isolate/rubygem-isola... Description: Isolate is a very simple RubyGems sandbox. It provides a way to express and automatically install your project's Gem dependencies.
Koji scratch build for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2628287 for F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2628289
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657591
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mgoldman@redhat.com AssignedTo|nobody@fedoraproject.org |mgoldman@redhat.com Flag| |fedora-review?
--- Comment #1 from Marek Goldmann mgoldman@redhat.com 2010-11-26 15:22:19 EST --- Taking this one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657591
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Marek Goldmann mgoldman@redhat.com 2010-11-26 15:56:27 EST --- Spec file:
* Micro issue: BR: rubygems is not required
Package:
* When requiring 'isolate/rake' (via README):
irb(main):001:0> require 'rubygems' => true irb(main):002:0> require 'isolate/rake' NoMethodError: undefined method `namespace' for main:Object from /usr/lib/ruby/gems/1.8/gems/isolate-3.0.0/lib/isolate/rake.rb:1 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' from (irb):2 from :0
I confirmed it with the 3.0.0 gem alone (uninstalled your package). If you require 'isolate/now' you still have the Rake tasks available. This is an upstream issue. Most probably README is outdated. It doesn't prevent to package it.
Otherwise - looks good!
------------------------------------------------------------ This package (rubygem-isolate) is APPROVED by goldmann ------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657591
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-11-26 16:34:57 EST --- (In reply to comment #2)
Package:
- When requiring 'isolate/rake' (via README):
- Well, lib/isolate/rake.rb is perhaps a "plugin" for rake, and actually: -------------------------------------------------------- [tasaka1@localhost ~]$ ruby -rubygems -e 'require "isolate/rake"' /usr/lib/ruby/gems/1.8/gems/isolate-3.0.0/lib/isolate/rake.rb:1: undefined method `namespace' for main:Object (NoMethodError) from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' from -e:1 [tasaka1@localhost ~]$ ruby -rubygems -e 'require "rake" ; require "isolate/rake"' [tasaka1@localhost ~]$ -------------------------------------------------------- So maybe it is better that lib/isolate/rake.rb contains "require 'rake'" at the top, however I guess this is okay for now.
Otherwise - looks good!
This package (rubygem-isolate) is APPROVED by goldmann
Thank you!
New Package SCM Request ======================= Package Name: rubygem-isolate Short Description: Very simple RubyGems sandbox Owners: mtasaka Branches: f13 f14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657591
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2010-11-29 12:21:13 EST --- For some reason this ticket contains an invalid unicode character, which prevents it from being queried via but bugzilla xmlrpc interface, which breaks our scripts.
I've processed this manually; please double check that everything branched OK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657591
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2010-12-10 11:13:56
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-12-10 11:13:56 EST --- Closing.
Thank you for review and git procedure.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657591
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mmorsi@redhat.com
--- Comment #6 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2011-01-11 14:54:59 EST --- *** Bug 668821 has been marked as a duplicate of this bug. ***
package-review@lists.fedoraproject.org