https://bugzilla.redhat.com/show_bug.cgi?id=1622685
Bug ID: 1622685 Summary: Review Request: nodejs-zeropad - Zeropad your integers with optional n-length padding Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rosser.bjr@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://tc01.fedorapeople.org/nodejs/discord-irc/nodejs-zeropad.spec SRPM URL: https://tc01.fedorapeople.org/nodejs/discord-irc/nodejs-zeropad-1.1.0-1.fc28...
Description: Zeropad your integers with optional n-length padding.
Fedora Account System Username: tc01
https://bugzilla.redhat.com/show_bug.cgi?id=1622685
Ben Rosser rosser.bjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1622684
--- Comment #1 from Ben Rosser rosser.bjr@gmail.com --- Add dependency on nodejs-negative-zero.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1622684 [Bug 1622684] Review Request: nodejs-negative-zero - Check if a number if negative zero
https://bugzilla.redhat.com/show_bug.cgi?id=1622685
Ben Rosser rosser.bjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1622686
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1622686 [Bug 1622686] Review Request: nodejs-irc-formatting - Turns IRC formatted text into easy to use blocks
https://bugzilla.redhat.com/show_bug.cgi?id=1622685
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Tests fail:
4 passing (9ms) 3 failing 1) zeropad throws when num is NaN: TypeError [ERR_AMBIGUOUS_ARGUMENT]: The "error/message" argument is ambiguous. The error message "zeropad requires a number or string" is identical to the message. at expectsError (assert.js:615:15) at Function.throws (assert.js:676:3) at Context.<anonymous> (test.js:32:16) 2) zeropad throws when length is NaN: TypeError [ERR_AMBIGUOUS_ARGUMENT]: The "error/message" argument is ambiguous. The error message "zeropad requires a positive integer for length" is identical to the message. at expectsError (assert.js:615:15) at Function.throws (assert.js:676:3) at Context.<anonymous> (test.js:38:16) 3) zeropad throws on negative length: TypeError [ERR_AMBIGUOUS_ARGUMENT]: The "error/message" argument is ambiguous. The error message "zeropad requires a positive integer for length" is identical to the message. at expectsError (assert.js:615:15) at Function.throws (assert.js:676:3) at Context.<anonymous> (test.js:44:16)
Node v10 has some additional assert sanity checks: if the thrown error message text equals the assert function call's descriptive message text argument, it reports this error. In order to fix this, you thus can change the message:
# Add tests to npm archive. # https://github.com/radiovisual/zeropad/pull/1 Source1: https://raw.githubusercontent.com/radiovisual/zeropad/3bd15b69384cc74d55ac2c...
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Package approved. Please fix the tests above before import.
https://bugzilla.redhat.com/show_bug.cgi?id=1622685
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-zeropad
https://bugzilla.redhat.com/show_bug.cgi?id=1622685
--- Comment #4 from Ben Rosser rosser.bjr@gmail.com --- Thanks for fixing the tests on node 10!
https://bugzilla.redhat.com/show_bug.cgi?id=1622685
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nodejs-zeropad-1.1.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-43c321e6ab
https://bugzilla.redhat.com/show_bug.cgi?id=1622685
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- nodejs-zeropad-1.1.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-43c321e6ab
https://bugzilla.redhat.com/show_bug.cgi?id=1622685 Bug 1622685 depends on bug 1622684, which changed state.
Bug 1622684 Summary: Review Request: nodejs-negative-zero - Check if a number if negative zero https://bugzilla.redhat.com/show_bug.cgi?id=1622684
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1622685
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-09-21 01:23:53
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-zeropad-1.1.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org