https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Bug ID: 1150445 Summary: Review Request: Random123 - Library of random number generator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sanjay.ankur@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ankursinha.fedorapeople.org/Random123/Random123.spec SRPM URL: https://ankursinha.fedorapeople.org/Random123/Random123-1.08-1.fc21.src.rpm
Description: Random123 is a library of "counter-based" random number generators (CBRNGs), in which the Nth random number can be obtained by applying a stateless mixing function to N instead of the conventional approach of using N iterations of a stateful transformation. CBRNGs were originally developed for use in MD applications on Anton, but they are ideal for a wide range of applications on modern multi-core CPUs, GPUs, clusters, and special-purpose hardware. Three families of non-cryptographic CBRNGs are described in a paper presented at the SC11 conference: ARS (based on the Advanced Encryption System (AES)), Threefry (based on the Threefish encryption function), and Philox (based on integer multiplication). They all satisfy rigorous statistical testing (passing BigCrush in TestU01), vectorize and parallelize well (each generator can produce at least 264 independent streams), have long periods (the period of each stream is at least 2128), require little or no memory or state, and have excellent performance (a few clock cycles per byte of random output). The Random123 library can be used with CPU (C and C++) and GPU (CUDA and OpenCL) applications.
Fedora Account System Username: ankursinha
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: Random123 - |Review Request: Random123 - |Library of random number |Library of random number |generator |generators
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
José Matos jamatos@fc.up.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jamatos@fc.up.pt
--- Comment #1 from José Matos jamatos@fc.up.pt --- I am willing to review this package.
Presently it fails in at least two instances: 1) on doxygen:
+ cd Random123-1.08 + pushd docs + doxygen . Error: file `.' not found
2) on latex: ! LaTeX Error: File `adjustbox.sty' not found.
There are two options, either you add BR tex(adjustbox.sty) or BR texlive-collection-latexextra that provides this and other latex packages.
Please fix this problems before proceeding with the review. :-)
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
--- Comment #2 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Hi Jose,
Thank you for reviewing this package. I've fixed the errors. Updated spec/srpm:
https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123.spe... https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123-1.0...
I'm using a copr repo to test the builds now: https://copr.fedoraproject.org/coprs/ankursinha/neuroscience-research/builds...
Cheers, Ankur
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1249094
--- Comment #3 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- *** Bug 1249097 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1249094 [Bug 1249094] Review Request: nrn - A flexible and powerful simulator of neurons and networks
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
José Matos jamatos@fc.up.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jamatos@fc.up.pt
--- Comment #4 from José Matos jamatos@fc.up.pt --- Hi Ankur, fedora-review raises two problems, that seem legitimate in my view. :-)
- If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
The license file is marked as %doc and not as license. If you intend to support EL6 or older, it is enough to add
%{!?_licensedir:%global license %doc}
- Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1454080 bytes in 68 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
This seems to me as a reasonable suggestion, what do you think?
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
--- Comment #5 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Hi Jose,
Makes sense.
Updated spec/srpm: https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123.spe... https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123-1.0...
Could you please set the review flag to the bug so that this doesn't show up on the "unaccepted review list"? :)
Thanks, Ankur
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
José Matos jamatos@fc.up.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #6 from José Matos jamatos@fc.up.pt --- (In reply to Ankur Sinha (FranciscoD) from comment #5)
Hi Jose,
Makes sense.
Updated spec/srpm: https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123.spe... https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123-1. 08-3.fc22.src.rpm
OK.
Could you please set the review flag to the bug so that this doesn't show up on the "unaccepted review list"? :)
:-)
Thanks for the remainder. :-)
In any case I set it to +. :-)
Thanks, Ankur
The package is easy, most of it is documentation. The license is acceptable and the spec well written following the fedora guidelines.
The package is approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Thanks for the quick review Jose!
New Package SCM Request ======================= Package Name: Random123 Short Description: Library of random number generators Upstream URL: http://www.deshawresearch.com/resources_random123.html Owners: ankursinha Branches: f22 f23 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #9 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- The scm request doesn't seem to have worked. Was advised to reset the flag.
New Package SCM Request ======================= Package Name: Random123 Short Description: Library of random number generators Upstream URL: http://www.deshawresearch.com/resources_random123.html Owners: ankursinha Branches: f22 f23 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- Random123-1.08-3.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/Random123-1.08-3.fc23
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- Random123-1.08-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/Random123-1.08-3.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- Random123-1.08-3.fc23 has been pushed to the Fedora 23 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |Random123-1.08-3.fc23 Resolution|--- |ERRATA Last Closed| |2015-08-14 22:07:21
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- Random123-1.08-3.fc23 has been pushed to the Fedora 23 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- Random123-1.08-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1150445
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|Random123-1.08-3.fc23 |1.08-3.fc22 Resolution|ERRATA |NEXTRELEASE
package-review@lists.fedoraproject.org