Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204228
Summary: Review Request: sleuthkit - Open Source forensic toolkit Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fedora-devel@mx-solutions.de QAContact: fedora-package-review@redhat.com
Spec URL: http://rindt.name/fileadmin/download/fedora/SPECS/sleuthkit.spec SRPM URL: http://rindt.name/fileadmin/download/fedora/SRPMS/sleuthkit-2.05-1.src.rpm Description: The Sleuth Kit is a collection of UNIX-based command line file system forensic tools that allow an investigator to examine NTFS, FAT, FFS, EXT2FS, and EXT3FS file systems of a suspect computer in a non-intrusive fashion.
The tools have a layer-based design and can extract data from internal file system structures. Because the tools do not rely on the operating system to process the file systems, deleted and hidden content is shown.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sleuthkit - Open Source forensic toolkit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204228
opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@till.name
------- Additional Comments From opensource@till.name 2006-08-27 07:04 EST ------- NTFS support in sleuthkit may not be allowed, see:
http://fedoraproject.org/wiki/ForbiddenItems#head-e52c1870d4467fe40c9da546fe... https://bugzilla.redhat.com/65749
As well you should look at: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Extras/Contributors
You seem not to be sponsored, so you need to block FE-NEEDSPONSOR.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sleuthkit - Open Source forensic toolkit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204228
------- Additional Comments From berrange@redhat.com 2006-09-02 13:00 EST ------- * The Packager & Vendor tags should not be included, nor refer to the Dag Wieers repository. Please remove them.
* The %setup macro is better invoked with the -q arg since there is no need to pollute build output with a list of files being extracted from the tar.gz
* The build process in the package is not honouring the $RPM_OPTS_FLAGS compiler settings. For example - its compiling with -O -g :
gcc -DLINUX2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DVER="2.05" -I../auxtools -I../imgtools -O -Wall -g -c -o jcat.o jcat.c
While current Fedora build flags are:
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
It would be very desirable to have the build process honour these options since they enable various security protection measures. A cursory look at the source code suggests it would probably need a patch applied to the Makefiles since they are hand-written instead of using AutoTools. IMHO, such a patch would be worthwhile, unless there are specific problems compiling the tools with these flags.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sleuthkit - Open Source forensic toolkit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204228
------- Additional Comments From fedora-devel@mx-solutions.de 2006-09-04 05:10 EST ------- (In reply to comment #1)
NTFS support in sleuthkit may not be allowed, see:
http://fedoraproject.org/wiki/ForbiddenItems#head-e52c1870d4467fe40c9da546fe...
https://bugzilla.redhat.com/65749
As well you should look at: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Extras/Contributors
You seem not to be sponsored, so you need to block FE-NEEDSPONSOR.
No one until today want to sponsor me... So grant me to review bad packages from me. The Guidelines i remmber me just in the moment that sleuthkit support ntfs. But i don't know how to disable. Possibly that the package review ends here. :/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sleuthkit - Open Source forensic toolkit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204228
------- Additional Comments From fedora-devel@mx-solutions.de 2006-09-04 05:13 EST ------- (In reply to comment #2)
- The Packager & Vendor tags should not be included, nor refer to the Dag Wieers
repository. Please remove them.
Yes i remove.
- The %setup macro is better invoked with the -q arg since there is no need to
pollute build output with a list of files being extracted from the tar.gz
Ok, will fix it.
- The build process in the package is not honouring the $RPM_OPTS_FLAGS compiler
settings. For example - its compiling with -O -g :
gcc -DLINUX2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DVER="2.05" -I../auxtools -I../imgtools -O -Wall -g -c -o jcat.o jcat.c
While current Fedora build flags are:
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
It would be very desirable to have the build process honour these options since they enable various security protection measures. A cursory look at the source code suggests it would probably need a patch applied to the Makefiles since they are hand-written instead of using AutoTools. IMHO, such a patch would be worthwhile, unless there are specific problems compiling the tools with these
flags.
I have tried with the standard flags but it seems that the -j3 is the problem. How i can filter it out?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sleuthkit - Open Source forensic toolkit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204228
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
------- Additional Comments From kevin@tummy.com 2006-10-02 20:33 EST ------- Since you are looking for sponsorship, you should take a look at:
http://fedoraproject.org/wiki/Extras/HowToGetSponsored
Adding FE-NEEDSPONSOR.
In reply to comment #4, perhaps you could ask the upstream source if they could change the setup to honor flags passed in? Otherwise you will have to look at patching the Makefile(s) yourself. :(
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sleuthkit - Open Source forensic toolkit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204228
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tummy.com OtherBugsDependingO|163776 | nThis| |
------- Additional Comments From kevin@tummy.com 2007-06-02 00:01 EST ------- Hey Daniel. Do you still wish to submit this package?
If so, could you post an updated src.rpm and spec file? If I don't hear from you I will close this in 1 week.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: sleuthkit - Open Source forensic toolkit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204228
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NOTABUG OtherBugsDependingO|177841 |201449 nThis| |
------- Additional Comments From kevin@tummy.com 2007-06-09 00:00 EST ------- I'm going to go ahead and close this submission now.
If you decide you want to continue, feel free to re-open it, or submit a new request.
package-review@lists.fedoraproject.org