Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-fakeweb - A tool for faking responses to HTTP requests
https://bugzilla.redhat.com/show_bug.cgi?id=633089
Summary: Review Request: rubygem-fakeweb - A tool for faking responses to HTTP requests Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mastahnke@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://stahnma.fedorapeople.org/reviews/rubygem-fakeweb.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/rubygem-fakeweb-1.3.0-1.fc15.src.rpm Description: FakeWeb is a helper for faking web requests in Ruby. It works at a global level, without modifying code or writing extensive stubs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-13 12:27:01 EDT --- Would you try to remove vendorized modules included in test/ directory?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #2 from Michael Stahnke mastahnke@gmail.com 2010-09-13 13:22:54 EDT --- Sure. I was going to ask on list how we handle things in vendor. Is there something in the package guidelines already for that?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-13 13:42:57 EDT --- Well, as shown in "general" packaging guidelines:
https://fedoraproject.org/wiki/Packaging/Guidelines#Bundling_of_multiple_pro...
we should seperate bundled other softwares from sources. Also see bug 470696 : Currently rubygem-passenger ships bundled boost and unless we remove this rubygem-passenger cannot be in Fedora.
Now I am listing rubygem based rpms on Fedora which ships vendorlized external gem, will post on ruby-sig.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #4 from Michael Stahnke mastahnke@gmail.com 2010-09-13 17:58:01 EDT --- Well, passenger ships a C lib, which may be different, but in general shoving it in vendor or use bundler are not solutions I like.
For this revisions I have added BuildRequires(check): rubygem(right_http_connection)
and patched out the two tests that require samuel. I may try to package up samuel eventually, but I have a LOT of packages I am already working on.
New SRPM: http://stahnma.fedorapeople.org/reviews/rubygem-fakeweb-1.3.0-2.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-16 17:41:43 EDT --- Sorry, I have not checked your last srpm yet, however I will surely review this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #6 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-17 12:26:50 EDT --- Now for 1.3.0-2:
* (Build)Requires - Writing >= 0.9.5 for rubygem(mocha) dependency is not needed because rubygem-mocha on currently supported Fedora/EPEL branches all satisfies this dependency: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
- "R: rubygem(mocha)" is not needed because this is for add_development_dependency in installed gemspec file and is not needed on runtime.
* %_geminstdir/*gemspec - Would you check if this is really needed? (Note that gemspec file is also installed under %gemdir/specifications/)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #7 from Michael Stahnke mastahnke@gmail.com 2010-09-17 14:03:18 EDT --- Removed the BR versioning.
Remove mocha as a runtime require.
Removed gemspec.
http://stahnma.fedorapeople.org/reviews/rubygem-fakeweb-1.3.0-3.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #8 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-17 16:57:23 EDT --- Okay.
----------------------------------------------------------- This package (rubygem-fakeweb) is APPROVED by mtasaka -----------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
Michael Stahnke mastahnke@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #9 from Michael Stahnke mastahnke@gmail.com 2010-09-17 17:26:23 EDT --- New Package SCM Request ======================= Package Name: rubygem-fakeweb Short Description: A tool for faking responses to HTTP Owners: stahnma Branches: F13 F14 EL5 EL6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #10 from Kevin Fenzi kevin@tummy.com 2010-09-19 15:26:01 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-09-19 20:11:16 EDT --- rubygem-fakeweb-1.3.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-fakeweb-1.3.0-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-09-19 20:11:21 EDT --- rubygem-fakeweb-1.3.0-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-fakeweb-1.3.0-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-09-20 14:41:15 EDT --- rubygem-fakeweb-1.3.0-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-fakeweb'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-fakeweb-1.3.0-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-09-28 01:48:10 EDT --- rubygem-fakeweb-1.3.0-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |rubygem-fakeweb-1.3.0-3.fc1 | |4 Resolution| |ERRATA Last Closed| |2010-09-28 01:48:14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-10-08 16:38:56 EDT --- rubygem-fakeweb-1.3.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|rubygem-fakeweb-1.3.0-3.fc1 |rubygem-fakeweb-1.3.0-3.fc1 |4 |3
package-review@lists.fedoraproject.org