https://bugzilla.redhat.com/show_bug.cgi?id=1283907
Bug ID: 1283907 Summary: Review Request: python2-humblewx - Library that simplifies creating user interfaces with wxPython Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: ricli85@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://rickardlindberg.users.sourceforge.net/python2-humblewx.spec SRPM URL: http://rickardlindberg.users.sourceforge.net/python2-humblewx-0.2.0-1.fc22.s... Description: Library that simplifies creating user interfaces with wxPython. Fedora Account System Username: rickardlindberg
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limburgher@gmail.com Assignee|nobody@fedoraproject.org |limburgher@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #1 from Jon Ciesla limburgher@gmail.com --- Well, it builds locally, imports into python when installed, and builds in mock. The license tag should be GPLv3+. Also, it would be really, really good if you were to rename it python-humblewx and have python2- and python3- packages. Python 3 support is gaining importance, and adding it here would be a good learning experience. ;)
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #2 from Rickard Lindberg ricli85@gmail.com --- I submitted a new review for the renamed package:
https://bugzilla.redhat.com/show_bug.cgi?id=1284159
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #3 from Jon Ciesla limburgher@gmail.com ---
From 1284159:
Spec URL: http://rickardlindberg.users.sourceforge.net/python-humblewx.spec SRPM URL: http://rickardlindberg.users.sourceforge.net/python-humblewx-0.2.1-1.fc22.sr... Description: Library that simplifies creating user interfaces with wxPython. Fedora Account System Username: rickardlindberg
- License changed to GPLv3+ - New upstream that contains AUTHORS and COPYING files
No Python 3 support was added because, as far as I know, the dependency wxPython does not yet work on Python 3.
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- *** Bug 1284159 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Ok, formal review:
- rpmlint checks return:
python2-humblewx.noarch: W: spelling-error Summary(en_US) wxPython -> python, Python The value of this tag appears to be misspelled. Please double-check.
python2-humblewx.noarch: W: spelling-error %description -l en_US wxPython -> python, Python The value of this tag appears to be misspelled. Please double-check.
Just needs capitalization.
- package meets naming guidelines - package meets packaging guidelines - license ( GPLv3+ ) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
I don't see an easy way to locate source tarballs but maybe that's the lack of coffee.
I'm actually looking into adding Python 3 support to wxPython. If I can I'll have you add it here, stay tuned.
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #6 from Rickard Lindberg ricli85@gmail.com --- I'm not sure how to fix the capitalization. The correct capitalization appears to be wxPython (see http://wxpython.org/).
rpmlint seems to accept WxPython, but that doesn't feel right.
Is there a standard way to fix this capitalization?
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Oh, duh. E_COFFEE. That is indeed correct, ignore that warning. :)
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #8 from Rickard Lindberg ricli85@gmail.com --- You can download the latest tarball here: https://pypi.python.org/pypi/humblewx
In the spec file, there is only a link to the actual tarball. Not to the website where you can click to download.
Should I add more links somewhere in the spec file?
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- No, just maybe either a link from the github page or set the pypi page as the homepage in the spec since that's where the tarballs live. Up to you.
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #10 from Rickard Lindberg ricli85@gmail.com --- (In reply to Jon Ciesla from comment #9)
No, just maybe either a link from the github page or set the pypi page as the homepage in the spec since that's where the tarballs live. Up to you.
Spec file updated to have URL point to PyPi.
Spec URL: http://rickardlindberg.users.sourceforge.net/python-humblewx.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Thanks.
Ok, so I give up, wxPython does *not* like Python 3 at this point. At all.
So, first of all, APPROVED.
Next, set up a FAS account and let me know the name, I couldn't find the one above.
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |python2-humblewx - Library |python-humblewx - Library |that simplifies creating |that simplifies creating |user interfaces with |user interfaces with |wxPython |wxPython
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #12 from Rickard Lindberg ricli85@gmail.com --- (In reply to Jon Ciesla from comment #11)
Thanks.
Ok, so I give up, wxPython does *not* like Python 3 at this point. At all.
I believe the Phoenix project is about porting wxPython to Python 3.
http://wxpython.org/Phoenix/docs/html/main.html
I don't think there is an official release yet though.
As far as I know, the "classic" wxPython probably will never work with Python 3.
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #13 from Rickard Lindberg ricli85@gmail.com --- (In reply to Jon Ciesla from comment #11)
Next, set up a FAS account and let me know the name, I couldn't find the one above.
My FAS name is rickardlindberg. It should be created.
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #14 from Jon Ciesla limburgher@gmail.com --- Ok, I see it. You're now a sponsored member of the packager group. Use your powers for good. ;) Now you can do the pkgdb request, import and build, as well as requesting access to timeline.
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #15 from Rickard Lindberg ricli85@gmail.com --- Thanks. Awaiting review for new package now.
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #16 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-humblewx
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- python-humblewx-0.2.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d51e2a92ee
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- python-humblewx-0.2.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d89c0c30ae
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #19 from Rickard Lindberg ricli85@gmail.com --- Ok, so I'm thinking the submission to f22 and f23 was maybe not right. I've read the update policy but find it a bit difficult to interpret.
The reason for creating this package was so that the timeline package (https://apps.fedoraproject.org/packages/timeline) could be updated to the latest version. Where do you think the latest timeline package should go? Only rawhide? f23 as well? Even longer back?
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- python-humblewx-0.2.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-humblewx' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d51e2a92ee
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- python-humblewx-0.2.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-humblewx' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d89c0c30ae
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- python-humblewx-0.2.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1283907
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2016-12-20 12:19:17
package-review@lists.fedoraproject.org