Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: gnome-shell-extension-no11y - remove acceblity icon from status area
https://bugzilla.redhat.com/show_bug.cgi?id=753677
Summary: Review Request: gnome-shell-extension-no11y - remove acceblity icon from status area Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: hedayaty@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y.spec SRPM URL: www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y-0-0.1.src.rpm Description: This is the extension to remove accessibility from status area, rewritten for gnome 3.2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2011-11-15 01:03:18 EST --- Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3514553 + rpmlint on package gave gnome-shell-extension-noa11y.noarch: W: no-version-in-last-changelog gnome-shell-extension-noa11y.noarch: W: invalid-url URL Note gnome-shell-extension-noa11y.noarch: W: no-documentation gnome-shell-extension-noa11y.noarch: W: empty-%postun gnome-shell-extension-noa11y.src: W: no-version-in-last-changelog gnome-shell-extension-noa11y.src: W: invalid-url URL Note gnome-shell-extension-noa11y.src: E: invalid-spec-name gnome-shell-extension-noa11y.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1) gnome-shell-extension-noa11y.src: W: invalid-url Source0: noa11y@hedayaty.gmail.com.tar.gz 2 packages and 0 specfiles checked; 1 errors, 8 warnings.
suggestions: 1) you don't need now following in current active Fedora releases. %defattr (-,root,root,-)
and in %install rm -rf %{buildroot}
2) add the version-release information in changelog like * Sun Nov 13 2011 Amir Hedayaty <hedayaty AT gmail DOT com>- 0-0.1 - Initial package for Fedora
3) you can remove warning mixed-use-of-spaces-and-tabs by using command sed -e 's|\t| |g' gnome-shell-extension-noa11y.spec
3) I see you have wrong spec file added in srpm. you added gnome-shell-extension-no11y.spec whereas it should be gnome-shell-extension-noa11y.spec
4) you don't need %postun in spec file. remove that.
5) Host your tarball on some server and use that download url in URL of spec.
submit a new SPEC and SRPM by fixing above issues.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #2 from Amir Hedayaty hedayaty@gmail.com 2011-11-15 02:40:06 EST --- Thanks for the feedback I hope the issue are fixed! Here are the new urls:
Spec URL: www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y.spec SRPM URL: www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y-3.2.0-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
Amir Hedayaty hedayaty@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #3 from Parag AN(पराग) panemade@gmail.com 2012-03-19 06:16:56 EDT --- Review:
+ koji scratch build for f17 -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3908553
+ rpmlint on rpms gave gnome-shell-extension-noa11y.noarch: W: no-documentation gnome-shell-extension-noa11y.src: W: invalid-url Source0: gnome-shell-extension-noa11y-3.2.0.tar.gz 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
+ upstream source URL is verified as (sha1sum) 7e59257df57d226a9b8f950a33a48a5f8db57152 ../SOURCES/gnome-shell-extension-noa11y-3.2.0.tar.gz 7e59257df57d226a9b8f950a33a48a5f8db57152 gnome-shell-extension-noa11y-3.2.0.tar.gz
+ package follows guidelines.
Suggestions: 1)Source tag should Source0: http://www.cs.sfu.ca/~aha49/personal/fedora/%%7Bname%7D-%%7Bversion%7D.tar.g...
2) URL tag should contain a link where this project is hosted. If its nowhere hosted then remove the URL tag.
3) Any reason for not using disttag? See http://fedoraproject.org/wiki/Packaging:DistTag how to add dist-tag.
4) Package is installed successfully but unable to get extension working. Look like you need to modify metadata.json to include new gnome-shell versions. I tested on f17 and this is not working. After adding "3.3.90" as gnome-shell version it start working.
Please fix the suggestions before you add this package in dist-git.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #4 from Parag AN(पराग) panemade@gmail.com 2012-03-19 06:18:33 EDT --- submit a new srpm with new source and I will approve it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #5 from Amir Hedayaty hedayaty@gmail.com 2012-03-19 14:19:08 EDT --- Here are the new rpm files,
http://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y.sp... http://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y-3....
They are targeted for FC16 and gnome 3.2 again. For gnome 3.4 I will update it hopefully soon! Existence of this extension is kind of ridiculous a similar one is the most popular extension on gnome! I wish gnome 3.4 added an option to hide that
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #6 from Parag AN(पराग) panemade@gmail.com 2012-03-22 04:56:08 EDT --- Package must work on current development version. Please make sure your extensions will work in F17 and F18.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #7 from Amir Hedayaty hedayaty@gmail.com 2012-03-28 15:19:35 EDT --- OK, the issue was solved somehow gnome-extension-tool did not enable the extensions! Here is the new version for gnome 3.4 and FC17 https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspee... https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspee...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #8 from Amir Hedayaty hedayaty@gmail.com 2012-03-28 15:20:56 EDT --- Oops Sorry messed them up! Here is the noa11y for gnome 3.4
https://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y-3... https://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y.s...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #9 from Parag AN(पराग) panemade@gmail.com 2012-04-16 23:47:58 EDT --- koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3996999
Fix the rpmlint warning gnome-shell-extension-noa11y.noarch: W: incoherent-version-in-changelog 3.4.0 ['3.4.0-1', '3.4.0-1'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package.
unable to verify sources wget http://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y-3.... ==> ERROR 404: Not Found.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #10 from Parag AN(पराग) panemade@gmail.com 2012-04-17 01:03:29 EDT --- one last thing, maybe I had overlooked but where can I see the license to verify? I see no separate license text file available in tarball, no license headers included in .js
you need to change 3.4.0 to 3.4.0-1 to fix rpmlint warning.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #11 from Amir Hedayaty hedayaty@gmail.com 2012-05-01 16:19:10 EDT --- Added copyright here as well
https://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y.s...
https://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y-3...
https://github.com/downloads/hedayaty/No-A11y/noa11y@hedayaty.gmail.com.tar....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #12 from Parag AN(पराग) panemade@gmail.com 2012-05-02 01:54:13 EDT --- rpmlint still shows
gnome-shell-extension-noa11y.noarch: W: incoherent-version-in-changelog 3.4.0 ['3.4.0-2', '3.4.0-2']
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #13 from Parag AN(पराग) panemade@gmail.com 2012-05-02 01:56:37 EDT --- Please read http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #14 from Parag AN(पराग) panemade@gmail.com 2012-05-02 02:02:23 EDT --- Anyway, I will not wait for this to get fixed.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #15 from Parag AN(पराग) panemade@gmail.com --- any update here?
https://bugzilla.redhat.com/show_bug.cgi?id=753677
--- Comment #16 from Parag AN(पराग) panemade@gmail.com --- any update here?
https://bugzilla.redhat.com/show_bug.cgi?id=753677
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(hedayaty@gmail.co | |m)
--- Comment #17 from Parag AN(पराग) panemade@gmail.com --- If I will not hear any updates in next one week, will close this as NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=753677
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Last Closed| |2012-09-25 05:39:25 Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG Flags|needinfo?(hedayaty@gmail.co | |m) |
package-review@lists.fedoraproject.org