https://bugzilla.redhat.com/show_bug.cgi?id=1399365
Bug ID: 1399365 Summary: Review Request: gap-pkg-xmod - Crossed Modules and Cat1-Groups for GAP Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loganjerry@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jjames.fedorapeople.org/gap-pkg-xmod/gap-pkg-xmod.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-xmod/gap-pkg-xmod-2.56-1.fc26.src.rp... Description: This package allows for computation with crossed modules, cat1-groups, morphisms of these structures, derivations of crossed modules and the corresponding sections of cat1-groups. Experimental functions for crossed squares are now included. In October 2015 a new section on isoclinism of crossed modules was added. Fedora Account System Username: jjames
https://bugzilla.redhat.com/show_bug.cgi?id=1399365
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |anto.trande@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1399365
--- Comment #1 from Antonio Trande anto.trande@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
== Issues ==
'URL' and 'Source0' look unreachable.
https://gap-packages.github.io/xmod/ (with a newer version (2.58))?
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 136 files have unknown license. Detailed output of licensecheck in /home/sagitter/1399365-gap-pkg-xmod/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://pages.bangor.ac.uk/~mas023/chda/xmod/xmod-2.56.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: gap-pkg-xmod-2.56-1.fc26.noarch.rpm gap-pkg-xmod-2.56-1.fc26.src.rpm gap-pkg-xmod.noarch: W: spelling-error %description -l en_US morphisms -> morph isms, morph-isms, isomorphic gap-pkg-xmod.noarch: W: spelling-error %description -l en_US isoclinism -> socialism gap-pkg-xmod.noarch: W: invalid-url URL: http://pages.bangor.ac.uk/~mas023/chda/xmod/xmod.html HTTP Error 404: Not Found gap-pkg-xmod.noarch: W: only-non-binary-in-usr-lib gap-pkg-xmod.src: W: spelling-error %description -l en_US morphisms -> morph isms, morph-isms, isomorphic gap-pkg-xmod.src: W: spelling-error %description -l en_US isoclinism -> socialism gap-pkg-xmod.src: W: invalid-url URL: http://pages.bangor.ac.uk/~mas023/chda/xmod/xmod.html HTTP Error 404: Not Found gap-pkg-xmod.src: W: invalid-url Source0: http://pages.bangor.ac.uk/~mas023/chda/xmod/xmod-2.56.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 8 warnings.
Rpmlint (installed packages) ---------------------------- gap-pkg-xmod.noarch: W: spelling-error %description -l en_US morphisms -> morph isms, morph-isms, isomorphic gap-pkg-xmod.noarch: W: spelling-error %description -l en_US isoclinism -> socialism gap-pkg-xmod.noarch: W: invalid-url URL: http://pages.bangor.ac.uk/~mas023/chda/xmod/xmod.html HTTP Error 404: Not Found gap-pkg-xmod.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
Requires -------- gap-pkg-xmod (rpmlib, GLIBC filtered): gap-core gap-pkg-autpgrp gap-pkg-gpd gap-pkg-hap gap-pkg-utils
Provides -------- gap-pkg-xmod: gap-pkg-xmod
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1399365 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1399365
--- Comment #2 from Jerry James loganjerry@gmail.com --- Indeed, the package home moved and there is a new version. New URLs:
Spec URL: https://jjames.fedorapeople.org/gap-pkg-xmod/gap-pkg-xmod.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-xmod/gap-pkg-xmod-2.58-1.fc26.src.rp...
https://bugzilla.redhat.com/show_bug.cgi?id=1399365
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Antonio Trande anto.trande@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1399365
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-xmod
https://bugzilla.redhat.com/show_bug.cgi?id=1399365
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- gap-pkg-xmod-2.58-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d14870fe5b
https://bugzilla.redhat.com/show_bug.cgi?id=1399365
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1399365
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- gap-pkg-xmod-2.58-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d14870fe5b
https://bugzilla.redhat.com/show_bug.cgi?id=1399365
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-12-19 01:02:11
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- gap-pkg-xmod-2.58-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org