https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Bug ID: 1000870 Summary: Review Request: nini - An uncommonly powerful .NET configuration library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: cickumqt@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://cicku.me/nini.spec SRPM URL: http://cicku.me/nini-1.1.0-1.fc21.src.rpm Description: Nini is an uncommonly powerful .NET configuration library designed to help build highly configurable applications quickly. Fedora Account System Username: cicku
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- 1. Package is noarch, so the -devel should not require %{name}%{?_isa}, just plain %{name}.
2. %description should be a bit more informative about what the library does, and should not repeat the blurb "uncommonly powerful" which doesn't really mean much.
3. The contents of the "Docs" directory could be moved one level up (so there would be /usr/share/doc/nini/Reference/, /usr/share/doc/nini/Manual).
- License is OK - package name is OK - spec is nice and clear - sources are downloadable and match the srpm - dist tag is there - no build root or other obsolete stuff - license is ok, file present and installed - latest version - follows Mono guidelines - %files is OK
rpmlint nini: nini.src:37: E: hardcoded-library-path in %{_prefix}/lib/nini nini.src:39: E: hardcoded-library-path in %{_prefix}/lib/nini/ nini.src:46: E: hardcoded-library-path in %{_prefix}/lib/nini/ It's OK per mono guidelines.
nini.src:41: W: macro-in-comment %{name} nini.src:41: W: macro-in-comment %{buildroot} nini.src:41: W: macro-in-comment %{_prefix} That comment could be removed.
nini.src: W: invalid-url Source0: http://downloads.sourceforge.net/project/nini/Nini/1.1.0/Nini-1.1.0.zip timed out Works for me.
% rpmlint nini-devel nini-devel.noarch: W: no-documentation nini-devel.noarch: W: spurious-executable-perm /usr/share/pkgconfig/nini.pc ${SOURCE1} should be -x.
Nice and clean module issues noted above.
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Christopher Meng cickumqt@gmail.com --- New Package SCM Request ======================= Package Name: nini Short Description: An uncommonly powerful .NET configuration library Owners: cicku Branches: f20
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- nini-1.1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nini-1.1.0-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nini-1.1.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nini-1.1.0-2.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW), | |605847 CC| |elsupergomez@gmail.com
--- Comment #6 from Christopher Meng cickumqt@gmail.com --- *** Bug 605840 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605847 [Bug 605847] Review Request: tangerine - Tangerine DAAP server
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i@stingr.net
--- Comment #7 from Christopher Meng cickumqt@gmail.com --- *** Bug 759139 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|201449 (FE-DEADREVIEW), | |605847 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605847 [Bug 605847] Review Request: tangerine - Tangerine DAAP server
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nini-1.1.0-1.fc20 has been pushed to the Fedora 20 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |nini-1.1.0-2.fc20 Resolution|--- |ERRATA Last Closed| |2013-12-13 22:01:02
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nini-1.1.0-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org