https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Bug ID: 1289717 Summary: Review Request: ViennaCL - Linear algebra and solver library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ilya.gradina@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec SRPM URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.0-1.fc24.src... Description: Linear algebra and solver library using CUDA, OpenCL, and OpenMP Fedora Account System Username: ilgrad
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |ViennaCL
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1276941 (fedora-neuro)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: ViennaCL - |Review Request: viennacl - |Linear algebra and solver |Linear algebra and solver |library |library using CUDA, OpenCL, | |and OpenMP Alias|ViennaCL |viennacl
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |i.gnatenko.brain@gmail.com
--- Comment #1 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Because I am owner of whole OpenCL stack - I will review this.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #2 from Igor Gnatenko i.gnatenko.brain@gmail.com ---
Group: Development/Libraries
not needed
ctest -VV ||:
Ignoring tests without informing upstream and without any comments is very bad.\
-DBUILD_EXAMPLES=ON \
but you are not including examples... Please add new doc subpackage and include examples and some documentation.
[brain@x1carbon ViennaCL-1.7.0]$ find ./CL/
./CL/ ./CL/cl.hpp ./CL/cl_platform.h ./CL/cl_gl_ext.h ./CL/cl_gl.h ./CL/opencl.h ./CL/cl.h ./CL/cl_ext.h ./CL/cl_d3d10.h
You MUST remove bundled opencl-headers.
Looks like you also need to install pocl into buildroot...
Not approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #3 from Ilya Gradina ilya.gradina@gmail.com --- New Spec URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec New SRPM URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.0-2.fc23.src...
tests: http://sourceforge.net/p/viennacl/mailman/message/34697733/
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Please put BuildRequires (and other tags) with one package per line. This makes things much easier to read (and diffs look better too).
Package looks good, but it seems that it doesn't make sense to release without the fixes queued for 1.7.1.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #5 from Ilya Gradina ilya.gradina@gmail.com --- New version 1.7.1 Spec URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec SRPM URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.1-1.fc24.src...
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/viennacl
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limburgher@gmail.com
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Retired, untagged all builds, review not approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ilya.gradina@gmai | |l.com)
--- Comment #8 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Ilya, what happened here? Do you still plan to package this?
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ilya.gradina@gmai | |l.com) |
--- Comment #9 from Ilya Gradina ilya.gradina@gmail.com --- Hi Zbigniew,
It was my mistake. How can I regain package on: ************ https://admin.fedoraproject.org/pkgdb/package/rpms/viennacl/ ************
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #10 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- I just needs to go through review.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #11 from Ilya Gradina ilya.gradina@gmail.com --- I realized is necessary to make a new review?
Now I have it: ******* fedpkg clone viennacl && cd viennacl && ls --> dead.package *******
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
--- Comment #12 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The review sets the review? flag.
(In reply to Ilya Gradina from comment #11)
I realized is necessary to make a new review?
No, just this one needs to be finished. I'll do it, unless Igor wants to do it.
Now I have it:
fedpkg clone viennacl && cd viennacl && ls --> dead.package
Yeah, you'll have to file a ticket to get the package unretired.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #13 from Ilya Gradina ilya.gradina@gmail.com --- Sorry, I do not know how me file a ticket to get the package unretired.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #14 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl ---
Request unretirement in Package Database by selecting the package and clicking "Ask unretirement" button. Specify all branches that need to be un-retired (inlcuding "master" for Rawhide, unless it is for EPEL only) and include the link to re-review.
from https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Cl...
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ignatenko@redhat. | |com)
--- Comment #15 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Igor, do you want to finish the review?
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ignatenko@redhat. | |com) |
--- Comment #16 from Igor Gnatenko ignatenko@redhat.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #15)
Igor, do you want to finish the review?
Yes, I will do review in Monday.
quick notes: remove magic numbers.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #17 from Igor Gnatenko ignatenko@redhat.com --- * Don't build examples as you don't really package it (you can put source code of them in -devel subpackage if it's not huge amount of data) and remove examples subpackage * Remove all magic numbers and if you need to exclude some test, write link to upstream bugreport * Own %dir %{_datadir}/cmake * Not sure if ./viennacl/tools/sha1.hpp used during compilation, if yes, then License should look like "MIT and ISC" * drop bundled opencl headers and use system ones from opencl-headers
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #18 from Igor Gnatenko ignatenko@redhat.com --- (In reply to Igor Gnatenko from comment #17)
- drop bundled opencl headers and use system ones from opencl-headers
Ignore this one, it's already done.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #19 from Ilya Gradina ilya.gradina@gmail.com --- (In reply to Igor Gnatenko from comment #17)
- Don't build examples as you don't really package it (you can put source
code of them in -devel subpackage if it's not huge amount of data) and remove examples subpackage
- Remove all magic numbers and if you need to exclude some test, write link
to upstream bugreport
- Own %dir %{_datadir}/cmake
- Not sure if ./viennacl/tools/sha1.hpp used during compilation, if yes,
then License should look like "MIT and ISC"
- drop bundled opencl headers and use system ones from opencl-headers
Hi Igor,
thx!
new spec: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec new srpm: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.1-2.fc26.src...
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #20 from Ilya Gradina ilya.gradina@gmail.com --- new spec: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec new srpm: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.1-3.fc26.src...
- fix license - fix path cmake - fix tests
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- viennacl-1.7.1-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b231f2b6d4
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- viennacl-1.7.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fe5ca8d90
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |manisandro@gmail.com
--- Comment #23 from Sandro Mani manisandro@gmail.com --- @Ilya Please build for rawhide also
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- viennacl-1.7.1-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b231f2b6d4
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- viennacl-1.7.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fe5ca8d90
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- viennacl-1.7.1-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fe5ca8d90
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- viennacl-1.7.1-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b231f2b6d4
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #28 from Ilya Gradina ilya.gradina@gmail.com --- (In reply to Sandro Mani from comment #23)
@Ilya Please build for rawhide also
sorry but I can not yet. https://pagure.io/releng/issue/6555
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-12-15 18:30:21
--- Comment #29 from Fedora Update System updates@fedoraproject.org --- viennacl-1.7.1-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #30 from Fedora Update System updates@fedoraproject.org --- viennacl-1.7.1-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1289717
--- Comment #31 from Fedora Update System updates@fedoraproject.org --- viennacl-1.7.1-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org