Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225699
Summary: Merge Review: dmraid Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: lvm-team@redhat.com
Fedora Merge Review: dmraid
http://cvs.fedora.redhat.com/viewcvs/devel/dmraid/ Initial Owner: lvm-team@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225699
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola@iki.fi AssignedTo|nobody@fedoraproject.org |jussi.lehtola@iki.fi Flag| |fedora-review?
--- Comment #1 from Jussi Lehtola jussi.lehtola@iki.fi 2009-03-24 10:34:59 EDT --- Taking on review.
A few quick notes: - Is Requires: ldconfig really necessary, as this is part of glibc?
- Source should be Source0.
- Why do you have --prefix=${RPM_BUILD_ROOT}/usr --sbindir=${RPM_BUILD_ROOT}/sbin --libdir=${RPM_BUILD_ROOT}/%{_libdir} --mandir=${RPM_BUILD_ROOT}/%{_mandir} --includedir=${RPM_BUILD_ROOT}/%{_includedir} as an argument to %configure? Isn't plain %configure with the other extra flags enough?
- Also, why do you install -m 755 -d $RPM_BUILD_ROOT{%{_libdir},/sbin,%{_sbindir},%{_bindir},%{_libdir},%{_includedir}/dmraid/,/var/lock/dmraid} isn't this automatically done by make install?
- Wouldn't using --enable-shared_lib prevent the need to remove the static library?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225699
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?
--- Comment #2 from Jussi Lehtola jussi.lehtola@iki.fi 2009-06-14 12:14:59 EDT --- ping lvm-team
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225699
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo? |
--- Comment #3 from Jussi Lehtola jussi.lehtola@iki.fi 2009-08-05 07:24:55 EDT --- ping again?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225699
--- Comment #4 from Jussi Lehtola jussi.lehtola@iki.fi 2010-01-01 17:44:12 EDT --- 3rd ping to lvm-team. Please respond.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225699
Zdenek Kabelac zkabelac@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zkabelac@redhat.com AssignedTo|jussi.lehtola@iki.fi |nobody@fedoraproject.org QAContact|fedora-package-review@redha |extras-qa@fedoraproject.org |t.com |
--- Comment #5 from Zdenek Kabelac zkabelac@redhat.com 2011-01-13 04:45:19 EST --- (In reply to comment #4)
3rd ping to lvm-team. Please respond.
Are these problems already fixed with current releases of lvm2 rpm (RHEL6) ?
package-review@lists.fedoraproject.org