https://bugzilla.redhat.com/show_bug.cgi?id=2105796
Bug ID: 2105796 Summary: Review Request: nagelfar - Syntax checker for Tcl Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: xavier.delaruelle@cea.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://xdelaruelle.fedorapeople.org/nagelfar.spec SRPM URL: https://xdelaruelle.fedorapeople.org/nagelfar-1.3.2-1.fc36.src.rpm
Description: Nagelfar is a Tcl application to read a Tcl program and provide static syntax analysis - information regarding Tcl syntax errors like missing braces, incomplete commands, etc. It is, moreover, extensible, with a customizable exposed syntax database and plugins. Nagelfar has also support for doing simple code coverage analysis.
Fedora Account System Username: xdelaruelle
https://bugzilla.redhat.com/show_bug.cgi?id=2105796
--- Comment #1 from Stephane Thiell sthiell@stanford.edu --- Hi Xavier,
Thanks for your contribution. I will be reviewing your package. The main problem is that it fails to build in mock on Fedora 36 because of a failed dependency on /usr/bin/tclsh:
+ /usr/lib/rpm/generate-rpm-note.sh nagelfar 1.3.2-1.fc36 x86_64 + cd nagelfar132 + ./test_nagelfar.sh /builddir/build/BUILDROOT/nagelfar-1.3.2-1.fc36.x86_64/usr/bin/nagelfar.tcl /builddir/build/BUILDROOT/nagelfar-1.3.2-1.fc36.x86_64/usr/share/nagelfar/syntaxdb.tcl misctests/test.tcl ./test_nagelfar.sh: /builddir/build/BUILDROOT/nagelfar-1.3.2-1.fc36.x86_64/usr/bin/nagelfar.tcl: /usr/bin/tclsh: bad interpreter: No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.lXpwtX (%check)
RPM build errors: Bad exit status from /var/tmp/rpm-tmp.lXpwtX (%check)
See: https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds
https://bugzilla.redhat.com/show_bug.cgi?id=2105796
Stephane Thiell sthiell@stanford.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2105796
--- Comment #2 from Xavier Delaruelle xavier.delaruelle@cea.fr --- Hi Stéphane,
Many thanks for your feedback. I have just updated SPEC file and SRPM to include a 'BuildRequires: tcl' statement as the script run in %check step needs /usr/bin/tclsh.
You could find updated files at the same location.
https://bugzilla.redhat.com/show_bug.cgi?id=2105796
Stephane Thiell sthiell@stanford.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2105796
Stephane Thiell sthiell@stanford.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Stephane Thiell sthiell@stanford.edu --- Looks good, thanks!
Adding rpmlint output of both src.rpm and installed rpm below FYI.
$ rpmlint -v nagelfar-1.3.2-1.fc36.src.rpm 331 blocks ================================================= rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
nagelfar.spec:27: W: macro-in-comment %check There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
================== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s =================
$ rpmlint -i nagelfar ================================================= rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
nagelfar.noarch: W: no-manual-page-for-binary nagelfar.tcl ================== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s =================
https://bugzilla.redhat.com/show_bug.cgi?id=2105796
Stephane Thiell sthiell@stanford.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |nagelfar
https://bugzilla.redhat.com/show_bug.cgi?id=2105796
--- Comment #4 from Xavier Delaruelle xavier.delaruelle@cea.fr --- Many thanks for your review. I have just fixed the "macro-in-comment %check" warning.
https://bugzilla.redhat.com/show_bug.cgi?id=2105796
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nagelfar
https://bugzilla.redhat.com/show_bug.cgi?id=2105796
Xavier Delaruelle xavier.delaruelle@cea.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2022-07-13 06:01:27
--- Comment #6 from Xavier Delaruelle xavier.delaruelle@cea.fr --- Package is pushed and built on rawhide (pending update on epel7, epel8 and epel9).
package-review@lists.fedoraproject.org