https://bugzilla.redhat.com/show_bug.cgi?id=981971
Bug ID: 981971 Summary: Review Request: python-landslide - Lightweight markup language-based html5 slideshow generator Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Assignee: nobody@fedoraproject.org Reporter: echevemaster@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://echevemaster.fedorapeople.org/python-landslide/python-landslide.spec SRPMS URL: http://echevemaster.fedorapeople.org/python-landslide/python-landslide-1.1.1... Description: Takes your Markdown, ReST, or Textile file(s) and generates fancy HTML5 slideshows Fedora Account System Username: echevemaster Tested on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5582023
https://bugzilla.redhat.com/show_bug.cgi?id=981971
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com Assignee|nobody@fedoraproject.org |cickumqt@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=981971
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #1 from Christopher Meng cickumqt@gmail.com --- No big problem.
1. main.py under %{python_sitelib}/landslide has env. rpmlint showed:
Requires -------- python-landslide (rpmlib, GLIBC filtered): /usr/bin/env (snip)
Ah, maybe should be patched, right?
2. MANIFEST.in should be removed from %doc.
3. Do you think it's a good idea or not that creating a subpackage "doc" to store the htmls?
4. rpmlint warned me about the license, seems that %{python_sitelib}/landslide/watcher.py has no license header.
https://bugzilla.redhat.com/show_bug.cgi?id=981971
--- Comment #2 from Eduardo Echeverria echevemaster@gmail.com --- Thank you @cicku
(In reply to Christopher Meng from comment #1)
No big problem.
- main.py under %{python_sitelib}/landslide has env. rpmlint showed:
Requires
python-landslide (rpmlib, GLIBC filtered): /usr/bin/env (snip)
Ah, maybe should be patched, right?
Not necessarily, although that is a good practice is a "SHOULD", anyway, is fixed in 2
- MANIFEST.in should be removed from %doc.
Yes, you're right
Fixed in 2
- Do you think it's a good idea or not that creating a subpackage "doc" to
store the htmls?
the complete documentation is approximately of 260 KB,thinking about the meaning of "large documentation", in this case don't applicable, see https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#...
- rpmlint warned me about the license, seems that
%{python_sitelib}/landslide/watcher.py has no license header.
Yes, watcher.py hasn't license header, but i don't see any rpmlint warning about that.
rpmlint -v python-landslide-1.1.1-1.fc19.src.rpm python-landslide.src: I: checking python-landslide.src: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show python-landslide.src: W: spelling-error %description -l en_US slideshows -> sideshows, slide shows, slide-shows python-landslide.src: I: checking-url https://pypi.python.org/pypi/landslide (timeout 10 seconds) python-landslide.src: I: checking-url https://github.com/adamzap/landslide/archive/a0078400c8e8f2fe19a754c0dbd55e7... (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint -v python-landslide-1.1.1-1.fc19.noarch.rpm python-landslide.noarch: I: checking python-landslide.noarch: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show python-landslide.noarch: W: spelling-error %description -l en_US slideshows -> sideshows, slide shows, slide-shows
anyway the package contains the boilerplate of the Apache License python-landslide.noarch: I: checking-url https://pypi.python.org/pypi/landslide (timeout 10 seconds) python-landslide.noarch: W: no-manual-page-for-binary landslide 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
anyway the package contains the boilerplate of the apache license
SPEC: http://echevemaster.fedorapeople.org/python-landslide/2/python-landslide.spe... SRPM: http://echevemaster.fedorapeople.org/python-landslide/2/python-landslide-1.1...
https://bugzilla.redhat.com/show_bug.cgi?id=981971
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Christopher Meng cickumqt@gmail.com --- OK.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=981971
Eduardo Echeverria echevemaster@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Eduardo Echeverria echevemaster@gmail.com --- New Package SCM Request ======================= Package Name: python-landslide Short Description: Lightweight markup language-based html5 slideshow generator Owners: echevemaster Branches: f18 f19 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=981971
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=981971
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=981971
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=981971
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-landslide-1.1.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-landslide-1.1.1-2.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=981971
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-landslide-1.1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-landslide-1.1.1-2.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=981971
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-landslide-1.1.1-2.fc18 has been pushed to the Fedora 18 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=981971
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-landslide-1.1.1-2.fc | |18 Resolution|--- |ERRATA Last Closed| |2013-08-11 14:28:06
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-landslide-1.1.1-2.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=981971
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-landslide-1.1.1-2.fc |python-landslide-1.1.1-2.fc |18 |19
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-landslide-1.1.1-2.fc19 has been pushed to the Fedora 19 stable repository.
package-review@lists.fedoraproject.org