Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-modjkapi - API for modjk management
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Summary: Review Request: python-modjkapi - API for modjk management Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tbielawa@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://people.redhat.com/~tbielawa/modjkapi/python-modjkapi.spec SRPM URL: http://people.redhat.com/~tbielawa/modjkapi/releases/modjkapi-latest/python-...
Description: Simple API for managing mod_jk via it's xml web api.
This is related to #701426
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Tim Bielawa tbielawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |701426, | |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |kevin@scrye.com Flag| |fedora-review?
--- Comment #1 from Kevin Fenzi kevin@scrye.com 2011-05-11 10:26:17 EDT --- I'll go ahead and review this.
Look for a full review hopefully later today.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #2 from Kevin Fenzi kevin@scrye.com 2011-05-11 11:55:02 EDT ---
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv3+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 72a6c9e090ca7ef20366a22235c658f7 modjkapi-0.1.2.28.tar.gz 72a6c9e090ca7ef20366a22235c658f7 modjkapi-0.1.2.28.tar.gz.orig
OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
Issues:
1. The /usr/bin/bleeder binary seems oddly named. Is there some history there?
2. rpmlint says:
python-modjkapi.noarch: W: no-manual-page-for-binary bleeder python-modjkapi.src: W: strange-permission modjkapi-0.1.2.28.tar.gz 0660L
Might set the perms to 644? Or might be something odd on my end. The man page warning you can ignore, but of course it's nice to add a man page too. ;)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #3 from Tim Bielawa tbielawa@redhat.com 2011-05-11 15:25:06 EDT --- (In reply to comment #2)
Spec URL remains the same: http://people.redhat.com/~tbielawa/modjkapi/python-modjkapi.spec
SRPM changed to: http://people.redhat.com/~tbielawa/modjkapi/releases/modjkapi-latest/python-...
Issues:
- The /usr/bin/bleeder binary seems oddly named. Is there some history there?
Heh, when used in context the name made more sense. It 'bleeds off connections' from a node in a load balancer pool, before removing the node -- but it also reenables nodes.
I've renamed it to something more descriptive: 'jk-rotate' because 'gracefully putting nodes into and out of rotation' is an easier concept to grok.
- rpmlint says:
python-modjkapi.noarch: W: no-manual-page-for-binary bleeder python-modjkapi.src: W: strange-permission modjkapi-0.1.2.28.tar.gz 0660L
Might set the perms to 644? Or might be something odd on my end.
Indeed, my umask was creating the sdist with those perms. This time before I built the srpm I manually set the perms to the recommended 0644.
The man page warning you can ignore...
Never
...but of course it's nice to add a man page too. ;)
I agree. Therefore I have added a man page, as per your suggestion.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Kevin Fenzi kevin@scrye.com 2011-05-11 15:43:57 EDT --- Excellent. That addresses everything I see, so this package is APPROVED.
I will go ahead and sponsor you. You can continue the process from:
https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source...
Please do let me know if you have any questions, either via email or catch me on irc (nick: nirik).
Welcome to the fun!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #5 from Tim Bielawa tbielawa@redhat.com 2011-05-11 21:51:38 EDT --- New Package SCM Request ======================= Package Name: python-modjkapi Short Description: API for modjk management Owners: tbielawa Branches: f14 f15 el5 el6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Tim Bielawa tbielawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #6 from Jason Tibbitts tibbs@math.uh.edu 2011-05-12 12:40:52 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Tim Bielawa tbielawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2011-05-12 16:29:34
--- Comment #7 from Tim Bielawa tbielawa@redhat.com 2011-05-12 16:29:34 EDT --- Koji builds complete:
- el5 - el6 - f14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-05-12 16:55:37 EDT --- python-modjkapi-0.1.2.28-7.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/python-modjkapi-0.1.2.28-7.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-05-12 16:56:15 EDT --- python-modjkapi-0.1.2.28-7.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-modjkapi-0.1.2.28-7.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-05-12 16:56:46 EDT --- python-modjkapi-0.1.2.28-7.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-modjkapi-0.1.2.28-7.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-05-24 23:00:50 EDT --- python-modjkapi-0.1.2.28-7.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |python-modjkapi-0.1.2.28-7. | |fc14 Resolution|NEXTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-06-02 15:14:11 EDT --- python-modjkapi-0.1.2.28-7.el5 has been pushed to the Fedora EPEL 5 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-modjkapi-0.1.2.28-7. |python-modjkapi-0.1.2.28-7. |fc14 |el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-06-02 15:25:47 EDT --- python-modjkapi-0.1.2.28-7.el6 has been pushed to the Fedora EPEL 6 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-modjkapi-0.1.2.28-7. |python-modjkapi-0.1.2.28-7. |el5 |el6
package-review@lists.fedoraproject.org