https://bugzilla.redhat.com/show_bug.cgi?id=1074595
Bug ID: 1074595 Summary: Review Request: systeminfo - simple utility for viewing HW Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: pavol.ipoth@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://www.symphaty.org/files/systeminfo.spec SRPM URL: http://www.symphaty.org/files/systeminfo-1.2-1.fc20.src.rpm Src URL: http://www.symphaty.org/files/systeminfo-1.2.tar.gz Description: Simple utility for viewing several types of HW Fedora Account System Username: p53
I am upstream developer package and i need sponsor as this is my first package
koji build: http://koji.fedoraproject.org/koji/tasks?owner=p53&state=all
https://bugzilla.redhat.com/show_bug.cgi?id=1074595
Johan Swensson kupo@kupo.se changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kupo@kupo.se Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1074595
Michael Schwendt bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1058038
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1058038 [Bug 1058038] Review Request: systeminfo - simple utility for viewing HW
https://bugzilla.redhat.com/show_bug.cgi?id=1074595
nicolas.vieville@univ-valenciennes.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.vieville@univ-valen | |ciennes.fr
--- Comment #1 from nicolas.vieville@univ-valenciennes.fr --- Hello,
I was in the way to propose you to make an unofficial review of this package (as I'm a Fedora candidate packager - need a sponsor), but I can see in https://bugzilla.redhat.com/show_bug.cgi?id=1058038 that Jeff Backus has already done it.
Is it still necessary? If this is still necessary, I'll tell Jeff Backus that this review request replaced your previous one, in case he would like to go further with his unofficial review.
Cordially,
https://bugzilla.redhat.com/show_bug.cgi?id=1074595
Ranjan Maitra itsme_410@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |itsme_410@yahoo.com
--- Comment #2 from Ranjan Maitra itsme_410@yahoo.com --- The links are dead.
https://bugzilla.redhat.com/show_bug.cgi?id=1074595
--- Comment #3 from Pavol Ipoth pavol.ipoth@gmail.com --- https://github.com/p53/systeminfo/releases/download/v1.2/systeminfo-1.2-1.fc... https://github.com/p53/systeminfo/releases/download/v1.2/systeminfo.spec https://github.com/p53/systeminfo/archive/v1.2.tar.gz
Here are live links
https://bugzilla.redhat.com/show_bug.cgi?id=1074595
--- Comment #4 from Ranjan Maitra itsme_410@yahoo.com --- Please update to a supported Fedora version. Also update changelog and the version number.
THere are many errors and issues.
1) If you are packaging python2 library or tools then your spec file should use %{__python2} macros only. See https://fedoraproject.org/wiki/Packaging:Python#Macros
2) Its always a good practice to increase the release number when you provide updated package here. That will help what has changed since your last package update to new package update.
3) Note that python packaging guidelines have changed (See https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file). You should change %build and %install to
%build %py2_build
%install py2_install
This should have the exact same effect, but is standard and more concise.
4) Please run fedora-review tool and go through the output: it will catch the same errors and issues for you and thus make review quicker than a back-and-forth.
https://bugzilla.redhat.com/show_bug.cgi?id=1074595
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com, | |pavol.ipoth@gmail.com Flags| |needinfo?(pavol.ipoth@gmail | |.com)
--- Comment #5 from Parag AN(पराग) panemade@gmail.com --- Pavol, Can you update the package with above suggestions?
https://bugzilla.redhat.com/show_bug.cgi?id=1074595
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Whiteboard| |AwaitingSubmitter Flags|needinfo?(pavol.ipoth@gmail | |.com) | Last Closed| |2016-12-15 01:37:44
--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- I don't see any update here which is waiting for Submitter to submit update. I am closing this review now. When needed to work this back in future, just re-open this review bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1074595
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org