https://bugzilla.redhat.com/show_bug.cgi?id=1403235
Bug ID: 1403235 Summary: Review Request: perl-Net-LDAP-SID - Net::LDAP::SID Perl module Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rc040203@freenet.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-SID.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-SID-0.001-1.fc26.sr... Description: Active Directory Security Identifier manipulation Fedora Account System Username: corsepiu
https://bugzilla.redhat.com/show_bug.cgi?id=1403235
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1312303
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1312303 [Bug 1312303] Review Request: perl-Net-LDAP-Server-Test - Test Net::LDAP code
https://bugzilla.redhat.com/show_bug.cgi?id=1403235
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1403235
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-Net-LDAP-SID-0.001-1.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Carp) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -qp --provides perl-Net-LDAP-SID-0.001-1.fc26.noarch.rpm | sort | uniq -c 1 perl(Net::LDAP::SID) = 0.001 1 perl-Net-LDAP-SID = 0.001-1.fc26 Binary provides are Ok.
$ rpmlint ./perl-Net-LDAP-SID* 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok
The package looks good. Approved
https://bugzilla.redhat.com/show_bug.cgi?id=1403235
--- Comment #2 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-LDAP-SID
https://bugzilla.redhat.com/show_bug.cgi?id=1403235
--- Comment #3 from Ralf Corsepius rc040203@freenet.de --- Thanks for the quick review. Provided my experiences with Fedora packaging in recent months, I feared this additional dep would delay perl-Net-LDAP-Server for yet another couple of months :(
https://bugzilla.redhat.com/show_bug.cgi?id=1403235
--- Comment #4 from Jitka Plesnikova jplesnik@redhat.com --- I can do the review of perl-Net-LDAP-Server next week, in case the perl-Net-LDAP-SID will be in rawhide.
https://bugzilla.redhat.com/show_bug.cgi?id=1403235
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2016-12-20 23:29:27
package-review@lists.fedoraproject.org