https://bugzilla.redhat.com/show_bug.cgi?id=1965529
Bug ID: 1965529 Summary: Review Request: icemon - A GUI monitor for Icecream Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jan.kratochvil@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: http://people.redhat.com/jkratoch/icemon.spec SRPM URL: http://people.redhat.com/jkratoch/icemon-3.3-6.fc34.src.rpm Description: A GUI monitor for Icecream, a distributed compiler system Fedora Account System Username: jankratochvil
https://bugzilla.redhat.com/show_bug.cgi?id=1965529
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Please use a more explicit name for the archive:
Source0: https://github.com/icecc/icemon/archive/v%%7Bversion%7D/%%7Bname%7D-%%7Bvers...
- Please justify the patch or link to an upstream PR/commit:
# Backport of docbook -> asciidoc from upstream # https://github.com/icecc/icemon/commit/479490ffbe0d13ed3059b67241671cb78521a... Patch1: icemon-asciidoc.patch
- The SPEC must be updated to the latest CMake guidelines, see https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/
%build %cmake %mcake_build
%install %cmake_install
[…]
%check %ctest
- Use https:
URL: https://kfunk.org/tag/icemon/
- End your description with a period;
%description A GUI monitor for Icecream, a distributed compiler system.
- The manpage should not be installed with %doc, and the manpage extension should be globbed as the compression may change in the future:
%{_mandir}/man1/icemon.1.*
- This could be simplified:
%{_datadir}/icons/hicolor/22x22/apps/icemon.png %{_datadir}/icons/hicolor/16x16/apps/icemon.png %{_datadir}/icons/hicolor/48x48/apps/icemon.png %{_datadir}/icons/hicolor/128x128/apps/icemon.png %{_datadir}/icons/hicolor/32x32/apps/icemon.png
→
%{_datadir}/icons/hicolor/*/apps/icemon.png
- Consider providing an Appdata file and validate it: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
- Add CHANGELOG.md and README.md to the %doc
%doc CHANGELOG.md README.md
https://bugzilla.redhat.com/show_bug.cgi?id=1965529
Jan Kratochvil jan.kratochvil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jan.kratochvil@redhat.com Flags| |needinfo?(zebob.m@gmail.com | |)
--- Comment #2 from Jan Kratochvil jan.kratochvil@redhat.com --- Thanks, in fact you did all the hard work.
Spec URL: http://people.redhat.com/jkratoch/icemon.spec SRPM URL: http://people.redhat.com/jkratoch/icemon-3.3-6.fc34.src.rpm metainfo: https://people.redhat.com/jkratoch/icemon.metainfo.xml
There is one issue but it works now: # FIXME: This command would install it to /usr/share/appdata . # DESTDIR=%{buildroot} appstream-util install %{SOURCE1} install -m644 -D %{SOURCE1} %{buildroot}/%{_metainfodir}/%{name}.metainfo.xml
https://bugzilla.redhat.com/show_bug.cgi?id=1965529
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ |needinfo?(zebob.m@gmail.com | |) |
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- LGTM, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1965529
Jan Kratochvil jan.kratochvil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |icemon-3.3-6.fc35 Resolution|--- |RAWHIDE Last Closed| |2021-06-04 06:15:33
package-review@lists.fedoraproject.org