https://bugzilla.redhat.com/show_bug.cgi?id=1312301
Bug ID: 1312301 Summary: Review Request: perl-Net-LDAP-Server - Net::LDAP::Server Perl module Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rc040203@freenet.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server-0.43-1.fc23.... Description: Net::LDAP::Server provides the protocol handling for an LDAP server. You can subclass it and implement the methods you need. Then you just instantiate your subclass and call its handle method to establish a connection with the client.
Fedora Account System Username: corsepiu
https://bugzilla.redhat.com/show_bug.cgi?id=1312301
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1312303
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1312303 [Bug 1312303] Review Request: perl-Net-LDAP-Server-Test - Test Net::LDAP code
https://bugzilla.redhat.com/show_bug.cgi?id=1312301
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com
--- Comment #1 from Petr Pisar ppisar@redhat.com --- Could you add `make' and `perl' to build-requires?
https://bugzilla.redhat.com/show_bug.cgi?id=1312301
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1312301
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed
BuildRequires FIX: Please add following BRs: - make - perl - perl-generators
FIX: Binary requires and provides are not complete due to missing BR perl-generators
$ rpmlint perl-Net-LDAP-Server* 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok
TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.
TODO: Please add 'examples' to %doc.
Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file.
The package is not approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1312301
--- Comment #3 from Ralf Corsepius rc040203@freenet.de --- Updated package with hopefully all issues addressed:
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server-0.43-2.fc26....
https://bugzilla.redhat.com/show_bug.cgi?id=1312301
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Jitka Plesnikova jplesnik@redhat.com --- (In reply to Jitka Plesnikova from comment #2)
BuildRequires FIX: Please add following BRs:
- make
- perl
- perl-generators
+BuildRequires: perl +BuildRequires: perl-generators ... +BuildRequires: %{__make} Ok.
FIX: Binary requires and provides are not complete due to missing BR perl-generators
$ rpm -qp --requires perl-Net-LDAP-Server-0.43-2.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Convert::ASN1) 1 perl(Data::Dumper) 1 perl(Net::LDAP::ASN) 1 perl(Net::LDAP::Constant) 1 perl(Net::LDAP::Entry) 1 perl(fields) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -qp --provides perl-Net-LDAP-Server-0.43-2.fc26.noarch.rpm | sort | uniq -c 1 perl(Net::LDAP::Server) = 0.43 1 perl-Net-LDAP-Server = 0.43-2.fc26 Binary provides are Ok.
TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +%{__make} pure_install DESTDIR=$RPM_BUILD_ROOT Ok.
TODO: Please add 'examples' to %doc.
+%doc examples Ok.
The package looks good. Approved
https://bugzilla.redhat.com/show_bug.cgi?id=1312301
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-LDAP-Server
https://bugzilla.redhat.com/show_bug.cgi?id=1312301
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2016-12-20 23:28:12
package-review@lists.fedoraproject.org