https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Bug ID: 1394193 Summary: Review Request: arduino-builder - A command line tool for compiling Arduino sketches Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: giallu@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://giallu.fedorapeople.org/arduino-builder.spec SRPM URL: https://giallu.fedorapeople.org/arduino-builder-1.0.5-1.fc24.src.rpm Description: This tool is able to parse Arduino Hardware specifications, properly run gcc and produce compiled sketches. An Arduino sketch differs from a standard C program in that it misses a main (provided by the Arduino core), function prototypes are not mandatory, and libraries inclusion is automagic (you just have to #include them). This tool generates function prototypes and gathers library paths, providing gcc with all the needed -I params.
Fedora Account System Username: giallu
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Gianluca Sforna giallu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1393796
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1393796 [Bug 1393796] Review Request: golang-github-go-errors-error - Package errors provides errors that have stack-traces
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Gianluca Sforna giallu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1316315
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1316315 [Bug 1316315] arduino-1.6.12 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Gianluca Sforna giallu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1316315 Depends On|1316315 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1316315 [Bug 1316315] arduino-1.6.12 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Dennis Chen barracks510@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |barracks510@gmail.com Assignee|nobody@fedoraproject.org |barracks510@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1394193 Bug 1394193 depends on bug 1393796, which changed state.
Bug 1393796 Summary: Review Request: golang-github-go-errors-errors - Package errors provides errors that have stack-traces https://bugzilla.redhat.com/show_bug.cgi?id=1393796
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #1 from Gianluca Sforna giallu@gmail.com --- Uploaded new spec file, now we are correctly building the package with golang dependencies.
Spec URL: https://giallu.fedorapeople.org/arduino-builder.spec SRPM URL: https://giallu.fedorapeople.org/arduino-builder-1.0.5-2.fc24.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Gianluca Sforna giallu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(barracks510@gmail | |.com)
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Dennis Chen barracks510@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ |needinfo?(barracks510@gmail | |.com) |
--- Comment #2 from Dennis Chen barracks510@gmail.com --- OK. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/arduino-builder
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- arduino-builder-1.0.5-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e26cf562b7
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- arduino-builder-1.0.5-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e3f59cacf
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- arduino-builder-1.0.5-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e3f59cacf
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- arduino-builder-1.0.5-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e26cf562b7
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Petr Viktorin pviktori@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pviktori@redhat.com
--- Comment #8 from Petr Viktorin pviktori@redhat.com --- Could you give some instructions on how to test this? Coming up with the required command line is beyond me.
Or, if it's really not easy to run arduino-builder by itself, I'd recommend just skipping the bodhi karma process and pushing it to Fedora to unblock Arduino IDE.
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #9 from Gianluca Sforna giallu@gmail.com --- (In reply to Petr Viktorin from comment #8)
Could you give some instructions on how to test this? Coming up with the required command line is beyond me.
Actually, it's beyond me too :)
Or, if it's really not easy to run arduino-builder by itself, I'd recommend just skipping the bodhi karma process and pushing it to Fedora to unblock Arduino IDE.
How? I think I requested a direct push to stable in bodhi, but it ended up in testing anyway so I pretty much assumed this was not skippable.
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Petr Viktorin pviktori@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@redhat.com
--- Comment #10 from Petr Viktorin pviktori@redhat.com --- (In reply to Gianluca Sforna from comment #9)
How? I think I requested a direct push to stable in bodhi, but it ended up in testing anyway so I pretty much assumed this was not skippable.
Right, seems it's not skippable.
But, what you can do is: * create a buildroot override containing arduino-builder at https://bodhi.fedoraproject.org/overrides/new * build arduino IDE using that * push both arduino and arduino-builder in a single Bodhi update. (If you're not the maintainer of both packages, ask a provenpackager to do it. I've added Miro who can do this for you once the new arduino is built.)
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #11 from Petr Viktorin pviktori@redhat.com --- ... But that's not necessary now, since after a week arduino-builder can be pushed to stable.
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #12 from Gianluca Sforna giallu@gmail.com --- I didn't push it yet because, while I was using the current package in testing to try out the updated arduino, I found a couple missing files for correct operations.
I'm spinning up a new update, I will put there a lower karma requirement so if you want to help we can push it to stable earlier.
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- arduino-builder-1.0.5-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e26cf562b7
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- arduino-builder-1.0.5-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e3f59cacf
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- arduino-builder-1.0.5-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e3f59cacf
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- arduino-builder-1.0.5-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e26cf562b7
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- arduino-1.6.6-2.fc25, arduino-builder-1.0.5-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c33ec5464a
https://bugzilla.redhat.com/show_bug.cgi?id=1394193
Gianluca Sforna giallu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2018-06-20 17:51:29
package-review@lists.fedoraproject.org