Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rubyripper - Open-source secure ripper for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=367341
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-10 07:35 EST ------- Well, for 0.4.3-1:
* EVR specific dependency between subpackages - Usually the dependency between subpackages must be EVR specific, i.e. "Requires: %{name} = %{version}-%{release}".
! Duplicate documents - Not a blocker, however I don't think "%doc GPL-3.txt README" is also needed for -gui package.
* Ruby module dependency - rubyripper (binary) rpm requires ruby(gettext-package) (not only BuildRequires). /usr/lib/ruby/site_ruby/1.8/rr_lib.rb : --------------------------------------------------------- 21 begin 22 require 'gettext' 23 rescue LoadError 24 puts "RubyGems is not found. Please install ruby-gettext." 25 end --------------------------------------------------------- (Note: rubygem is not needed)