Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204164
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-09-02 15:32 EST ------- I'll assume that the BuildRequires: perl(Digest::SHA1) is added to the spec for the purposes of this review.
* source files match upstream: d611b72884406ed92b7920be76bb3a94 LWP-Authen-Wsse-0.05.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. O BuildRequires are proper (BR: perl is not necessary; assuming BR: perl(Digest::SHA1) is there). * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(LWP::Authen::Wsse) perl-LWP-Authen-Wsse = 0.05-1.fc6 = perl >= 0:5.004 perl(:MODULE_COMPAT_5.8.8) perl(Digest::SHA1) perl(English) perl(MIME::Base64) perl(constant) perl(strict) perl(warnings) * %check is present and the single test passes: All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.01 cusr + 0.02 csys = 0.03 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings.
APPROVED, assuming you add that missing BR.