Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=722640
Pierre-YvesChibon pingou@pingoured.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review?
--- Comment #1 from Pierre-YvesChibon pingou@pingoured.fr 2011-09-06 10:35:25 EDT --- * Latest version packaged Target is already in the folder, no need to re-download it 6d739af03ac690f15b08ac91816951f6360d2464 qcc_2.0.1.tar.gz 6d739af03ac690f15b08ac91816951f6360d2464 ~/rpmbuild/SOURCES/qcc_2.0.1.tar.gz * sha1sum are equals ! Not all mandatory Requires are present, missing ['R-core'] * All required BuildRequires are present * The macro %check is present * There is 1 %dir %dir is OK * There is 3 %doc * More element than expected in %doc (CITATION has been added) * The rpm installed in _datadir * The rpm uses %{_datadir} and is noarch * The rpm seems to have the required element in %install * Build properly under 2.6.35.14-95.fc14.x86_64 Logs are clean. * rpmlint: R-qcc.noarch: E: incorrect-fsf-address /usr/share/R/library/qcc/COPYING R-qcc.noarch: W: wrong-file-end-of-line-encoding /usr/share/R/library/qcc/CITATION R-qcc.noarch: W: one-line-command-in-%post /usr/lib/rpm/R-make-search-index.sh R-qcc.noarch: W: one-line-command-in-%postun /usr/lib/rpm/R-make-search-index.sh 2 packages and 0 specfiles checked; 1 errors, 3 warnings. You can correct all of them.
* Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3327296 0 free 0 open 2 done 0 failed 3327296 build (f16, R-qcc-2.0.1-1.fc15.src.rpm) completed successfully
Additionally: You may want to check http://fedoraproject.org/wiki/Packaging:R as the template has changed a little bit.
Requires(post): R Requires(postun): R ... %post %{_R_make_search_index} %postun %{_R_make_search_index}
These lines are not needed anymore.
Requires: R
This should be R-core (as mentioned above)
Regarding the license: - GPLv2+ is a valid license for Fedora and consistently used in the sources. - Could you check with upstream if they/we are allowed to redistribute the files: qcc/inst/doc/qcc_Rnews.pdf (article from the R news paper) qcc/demo/process.variation.R (seem to come from a book)