https://bugzilla.redhat.com/show_bug.cgi?id=976468
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #2 from Vít Ondruch vondruch@redhat.com --- (In reply to Marcelo Barbosa from comment #1)
Hi Adam,
I'm reviewing your package, please see this issues:
Issues:
- gems should require rubygems package Note: Requires: rubygems missing in rubygem-teamocil-doc See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems
The -doc subpackage is requiring the main package, which requires ruby(rubygems), so this should be OK IMO.
- Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/gems/gems/teamocil-0.4.4 See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
Yes, the %{gem_instdir} (without the %dir macro) should be removed.
* Use %gem_install macro - Could you please use %gem_install as per latest Ruby packaging guidelines [1]. - Please note that latest gem2rpm supports this macro out of the box. You should use "-t fedora-19-rawhide" template specifier though.
* Use ruby(release) instead of ruby(abi) - Latest guidelines requires you to use ruby(release) virtual provide instead of ruby(abi) [2]. Please update your .spec file appropriately.
[1] https://fedoraproject.org/wiki/Packaging:Ruby#Building_gems [2] https://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Compatibility