Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pygpgme - Python module for working with OpenPGP messages
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210217
------- Additional Comments From toshio@tiki-lounge.com 2006-10-15 04:04 EST ------- (In reply to comment #2)
- rpmlint output:
E: pygpgme unknown-key GPG#cd84ee48
That would be my gpg key. Which means you're probably running rpmlint over the SRPM I provided instead of the one that you rebuilt. (The ones that you rebuild will have no signature... which Fedora's rpmlint doesn't complain about.) This should be fine but you may want to run rpmlint on the generated srpm/rpm to make sure there's no problems that show up on your build but not mine.
The another problem is lack of license file in %doc, but according to guidelines: "If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc" so that's not a problem. And the last thing is package license. You've written LGPL as license but I couldn't find any information about that (no COPYING, nothing on website) so please show me reliable source where I can find license info.
It's in the PKG-INFO %doc file.
http://cheeseshop.python.org/pypi/pygpgme/0.1 lists the module as LGPL. I also checked out the development version using bzr:
bzr branch http://www.gnome.org/~jamesh/bzr/pygpgme
and there's a COPYING file present there with the LGPL text. So I can include that when the next release occurs.
I'll repoint the spec URL at cheeseshop.python.org to make this clearer:
Spec URL: http://www.tiki-lounge.com/~toshio/fedora/pygpgme.spec SRPM URL: http://www.tiki-lounge.com/~toshio/fedora/pygpgme-0.1-2.src.rpm
* Fri Oct 13 2006 Toshio Kuratomi toshio@tiki-lounge.com - 0.1-2 - Change URL to cheeseshop