https://bugzilla.redhat.com/show_bug.cgi?id=1150445
José Matos jamatos@fc.up.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jamatos@fc.up.pt
--- Comment #4 from José Matos jamatos@fc.up.pt --- Hi Ankur, fedora-review raises two problems, that seem legitimate in my view. :-)
- If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
The license file is marked as %doc and not as license. If you intend to support EL6 or older, it is enough to add
%{!?_licensedir:%global license %doc}
- Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1454080 bytes in 68 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
This seems to me as a reasonable suggestion, what do you think?