Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504476
--- Comment #11 from Matthew Kent mkent@magoazul.com 2010-01-02 03:25:36 EDT --- (In reply to comment #7)
SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-newgem.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-newgem-1.5.2-1.fc11.src....
Matthew: Feel free to help. I'd be glad and thankful if you could (co-)maintain this once it's in.
Sure thing. I'm now requiring this for another package I'm working on so I'll post my update. I tried to record my modifications in the changelog. Hopefully they all make sense.
Only other improvement I'd like to make is to break the ri/rdoc content, tests and Rakefile into a separate -doc package giving the main one a smaller footprint. Any issue with that?
(In reply to comment #8)
1] rpmlint complaining rubygem-newgem.noarch: W: incoherent-version-in-changelog 1.4.1-3 ['1.5.2-1.fc12', '1.5.2-1'] rubygem-newgem.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/rubygems_generators/executable/templates/bin/app.rb.erb 0644 /usr/bin/env rubygem-newgem.noarch: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/test/fixtures/home/.rubyforge rubygem-newgem.noarch: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/test/fixtures/home/.rubyforge rubygem-newgem.noarch: E: zero-length /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/website/version.js rubygem-newgem.noarch: E: zero-length /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/newgem_theme_generators/plain_theme/USAGE rubygem-newgem.noarch: E: zero-length /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/app_generators/newgem_simple/templates/lib/templates.rb rubygem-newgem.noarch: W: wrong-file-end-of-line-encoding /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/test/test_helper.rb rubygem-newgem.noarch: E: zero-length /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/newgem_theme_generators/long_box_theme/USAGE rubygem-newgem.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/app_generators/newgem/templates/script/console.erb 0644 /usr/bin/env rubygem-newgem.noarch: E: zero-length /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/rubygems_generators/executable/USAGE rubygem-newgem.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/newgem-1.5.2/newgem_generators/install_website/templates/script/txt2html 0644 /usr/bin/env 2 packages and 0 specfiles checked; 8 errors, 4 warnings.
*license ok *naming ok *spec file legible *build ok
please fix rpmlint messages
I've fixed the one regarding the crlf issue but the others are harder to quash as they are all templates/placeholder files used by newgem to create new projects. Is there a nicer way to have rpmlint ignore these? For now I've added a note in the spec file.
SPEC file here and in src.rpm seems different