https://bugzilla.redhat.com/show_bug.cgi?id=1867321
--- Comment #3 from Igor Raits igor.raits@gmail.com --- New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ansibl... New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ansibl...
--- Comment #3 from Igor Raits igor.raits@gmail.com --- Hi Andy,
Thank you for review! For sure ansible-collections-netbox-netbox is my package and I am creator of all those packaging-related macros for Ansible :)
licensecheck reports extra licenses:
I somehow did not notice this, I've fixed it in spec and also opened issue in upstream https://github.com/ansible-collections/ansible.netcommon/issues/116.
Is the "python3-rpm-macros" package not needed by the netcommon Ansible module?
No, it was needed there only for %{python3_version} macro that is used in Requires.
I noticed that ansible-collection-netbox-netbox in addition removes the integration tests and does some sed cleanup magic:
Yeah, probably we should do same, fixed.
I somehow don't think Ansible uses these internally, but I might be wrong. If these are not actually a part of the package, they should be removed.
Fixed.