https://bugzilla.redhat.com/show_bug.cgi?id=1955618
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ppisar@redhat.com | |) |
--- Comment #2 from Petr Pisar ppisar@redhat.com --- (In reply to Peter Oliver from comment #1)
- Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
Good catch. I updated the spec file to only use the macro form.
- It it useful to package the tests, rather than running them only at build time?
The packaged tests exhibit code installed into the system location, while the tests run at a build-time exhibit code under in a nonsystem location. These two can (e.g. by a mistake) differ. I use the package tests in gating tests which are performed by Bodhi system.
Also the packaged tests can be run any later and validate the system on user's request. E.g. when a dependency changes. This is superhandy when gating foreign builds with tests of its reverse dependencies.
- The following message is issued during the build. Are you sure it’s okay
to leave out this dependency?
Checking prerequisites... test_requires: ! Test::Fatal is not installed
Yes. I'm pretty sure and upstream acknowledged it https://rt.cpan.org/Public/Bug/Display.html?id=136386.