Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479750
--- Comment #2 from Monty cmontgom@redhat.com 2009-01-12 17:23:52 EDT ---
The only real issue i see is that you need to Requires: pkg-config since you ship .pc files
Fixed
- you run make check in %build but normally you'd run that in %check
Changed
- you mix tabs and spaces
Emacs is doing that mainly because the .emacs file config to make it stop seems to change every minor release and I'm sick of fixing it every time I update.
- the tarball in the srpm is 0600 instead of 0644 or whatever
Changed
4) You're changelog entry doesn't have a version at the end of it.
Fixed
I've refreshed the files at http://people.xiph.org/~xiphmont/CELT with the above changes.