Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pydotconf - python parser for dot.conf file
https://bugzilla.redhat.com/show_bug.cgi?id=454921
------- Additional Comments From goyal.hemant@gmail.com 2008-07-11 15:24 EST ------- Hi Kyle,
Thanks for the review.
SPEC URL : http://www.nsitonline.in/hemant/stuff/python-dotconf/rpm/python-dotconf.spec
SRPM URL: http://www.nsitonline.in/hemant/stuff/python-dotconf/rpm/python-dotconf-0.2-...
In particular, don't include a Vendor, don't define things like name and
version, needlessly, Source0 should be an URL, URL should be the package's home page, and the package needs to be named python-pydotconf.
Yes this was my mistake, I directly worked on the SPEC generated by disutils bdist command. I have use the rpmdev (python) SPEC template now.
(Not to mention that putting "py" in the name of your python library is a bit silly. Why not just name it dotconf? Also, you should consider reading PEP-8 and just rolling everything into a single dotconf.py instead of a directory... it's only about 350 lines.)
Hmmm, thanks for the idea. I ve merged the two files into dotconf.py now. Are you also suggesting that I do not include the file in a directory like dotconf?
Thanks, Hemant