https://bugzilla.redhat.com/show_bug.cgi?id=1672272
--- Comment #2 from Jakub Jelen jjelen@redhat.com --- (In reply to Robert-André Mauchin from comment #1)
- For a development snapshot the Release info should contain the snapshot
date and the shortcommit:
Release: 0.1.%{snapshotdate}git%{shortcommit0}%{?dist}
Thank you. I do not know how I forgot this one. Fixed in the following update.
- The description should be split to stay below 80 characters per line:
%description PKCS #11 is a Public-Key Cryptography Standard that defines a standard method to access cryptographic services from tokens/ devices such as hardware security modules (HSM), smart cards, etc. In this project we intend to use a TPM2 device as the cryptographic token.
- The LICENSE file must be installed with %license in %files
%license LICENSE
Thanks. Fixed.
- These files should be in a -devel subpackage:
%{_libdir}/pkgconfig/tpm2-pkcs11.pc %{_libdir}/pkcs11/libtpm2_pkcs11.so
No, they are intentionally not in the devel subpackage, since the .so file is not a file to be used for development, but it is a PKCS#11 module which is intended to be used by end users. This part is not yet clarified in the packaging guidelines, but I already proposed a change to have it right (as it is this way already in many other packages: opensc, yubihs-shell, softhsm, p11-kit ...):
https://pagure.io/packaging-committee/pull-request/856
The .pc file should not be needed either.
- There's a typo in the Source0 URL (%{commit} instead of %{commit0}, it
should be:
Source0: https://github.com/tpm2-software/tpm2-pkcs11/archive/%%7Bcommit0%7D.tar.gz#/ %{name}-%{version}-git%{shortcommit0}.tar.gz
Thanks. Fixed.
I updated also the package to the latest commit.
Spec URL: https://jjelen.fedorapeople.org/tpm2-pkcs11.spec SRPM URL: https://jjelen.fedorapeople.org/tpm2-pkcs11-0-0.20190219git836d715.fc30.src....
Changelog and built status is available in copr:
https://copr.fedorainfracloud.org/coprs/jjelen/tpm2-pkcs11/build/860093/