Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xorg-x11-xcalc - X.org XCalc
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204513
------- Additional Comments From amlai@columbia.edu 2006-10-08 18:02 EST ------- (In reply to comment #16)
- the icon is not placed rightly. It should better be in
%{_datadir}/icons/hicolor/48x48/apps/xcalc.png
Since the icon isnn't exactly high color, really isn't high res, and it seemed that others (e.g. AbiWord) placed the icon in that directory, I figured that was the appropriate location. Regardless, icon is now in that directory.
- you should then use the scriplet
Corrected.
- this is only a remark, not a blocker, but I prefer using install over cp, since with install you can set explicitely the permissions you want with -m.
Agreed.
I also removed the Version from the .desktop file.
Spec URL: http://www.columbia.edu/~amlai/xcalc/xcalc.spec SRPM URL: http://www.columbia.edu/~amlai/xcalc/xcalc-1.0.1-4.fc5.src.rpm